On Fri, Dec 03, 2021 at 05:46:51PM +, Bossart, Nathan wrote:
> Perhaps this patch should be marked Rejected in favor of that one,
> then.
Let's do so, then. I can also get behind the coverage argument for
this code path.
--
Michael
signature.asc
Description: PGP signature
On 12/3/21, 7:40 AM, "Peter Geoghegan" wrote:
> If my patch to unite vacuum verbose and the autovacuum logging gets
> in, then this issue also goes away.
Perhaps this patch should be marked Rejected in favor of that one,
then.
Nathan
If my patch to unite vacuum verbose and the autovacuum logging gets in,
then this issue also goes away.
Peter Geoghegan
(Sent from my phone)
Hi,
On 2021-12-03 09:53:22 +0900, Michael Paquier wrote:
> On Thu, Dec 02, 2021 at 10:22:25PM +, Bossart, Nathan wrote:
> > Since I have no further comments, I went ahead and marked this once as
> > ready-for-committer.
>
> Well, as you say, lazy_scan_heap() is only run once per relation, so
On Thu, Dec 02, 2021 at 10:22:25PM +, Bossart, Nathan wrote:
> Since I have no further comments, I went ahead and marked this once as
> ready-for-committer.
Well, as you say, lazy_scan_heap() is only run once per relation, so
that's not a hot code path. Looking at the callers of
On 10/29/21, 10:49 AM, "Bossart, Nathan" wrote:
> On 10/29/21, 3:54 AM, "Greg Nancarrow" wrote:
>> When recently debugging a vacuum-related issue, I noticed that there
>> is some log-report processing/formatting code at the end of
>> lazy_scan_heap() that, unless the vacuum VERBOSE option is
On 10/29/21, 3:54 AM, "Greg Nancarrow" wrote:
> When recently debugging a vacuum-related issue, I noticed that there
> is some log-report processing/formatting code at the end of
> lazy_scan_heap() that, unless the vacuum VERBOSE option is specified,
> typically results in no log output (as the
Hi,
When recently debugging a vacuum-related issue, I noticed that there
is some log-report processing/formatting code at the end of
lazy_scan_heap() that, unless the vacuum VERBOSE option is specified,
typically results in no log output (as the log-level is then DEBUG2).
I think it is worth
