> On 30 Aug 2022, at 23:08, Bruce Momjian wrote:
> On Sun, Aug 28, 2022 at 03:06:09PM -0700, Nathan Bossart wrote:
>> The patch looks reasonable to me.
>
> +1. Those checks have accumulated over time with different authors,
> hence the stylistic differences.
Pushed, thanks for review!
--
On Sun, Aug 28, 2022 at 03:06:09PM -0700, Nathan Bossart wrote:
> On Sun, Aug 28, 2022 at 10:42:24PM +0200, Daniel Gustafsson wrote:
> > I noticed that the pg_upgrade check_ functions were determining failures
> > found
> > in a few different ways. Some keep a boolen flag variable, and some
On Sun, Aug 28, 2022 at 10:42:24PM +0200, Daniel Gustafsson wrote:
> I noticed that the pg_upgrade check_ functions were determining failures found
> in a few different ways. Some keep a boolen flag variable, and some (like
> check_for_incompatible_polymorphics) check the state of the script
I noticed that the pg_upgrade check_ functions were determining failures found
in a few different ways. Some keep a boolen flag variable, and some (like
check_for_incompatible_polymorphics) check the state of the script filehandle
which is guaranteed to be set (with the error message referring to
