Re: Some incorrect logs in TAP tests of pgbench

2021-06-25 Thread Fabien COELHO
(What were we thinking in allowing this in the first place?) Temporary debug leftovers that got through, I'd say. Thanks Michaƫl for the clean up! -- Fabien.

Re: Some incorrect logs in TAP tests of pgbench

2021-06-25 Thread Michael Paquier
On Fri, Jun 25, 2021 at 09:37:50AM -0400, Andrew Dunstan wrote: > Either that or dereference them, by printing @$out and @$err instead of > $out and $err or something similar. Looking again, we don't really lose context if we remove that, so done this way. > But probably the name of the test is

Re: Some incorrect logs in TAP tests of pgbench

2021-06-25 Thread Alvaro Herrera
On 2021-Jun-25, Michael Paquier wrote: > I am a bit dubious that this information is useful when it comes to > debugging because we have the name of the tests close by, so I would > just remove those extra logs. If people prefer keeping this > information around, we could fix the format with

Re: Some incorrect logs in TAP tests of pgbench

2021-06-25 Thread Andrew Dunstan
On 6/25/21 8:33 AM, Michael Paquier wrote: > Hi all, > > While digging into some of the TAP tests, I have noticed that > 002_pgbench_no_server.pl prints array pointers, like that: > opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990), > err=ARRAY(0x14028dc40), name=pgbench option error: no

Some incorrect logs in TAP tests of pgbench

2021-06-25 Thread Michael Paquier
Hi all, While digging into some of the TAP tests, I have noticed that 002_pgbench_no_server.pl prints array pointers, like that: opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990), err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running: pgbench -f no-such-file I am a bit dubious