Re: Support specify tablespace for each merged/split partition

2024-08-07 Thread Junwang Zhao
Hi Fujii, Thanks for your review. On Wed, Aug 7, 2024 at 9:54 PM Fujii Masao wrote: > > > > On 2024/08/06 19:28, Junwang Zhao wrote: > > Attached v2 addressed all the problems you mentioned, thanks. > > Thanks for updating the patches! > > > In the ALTER TABLE documentation, v1 patch updated the

Re: Support specify tablespace for each merged/split partition

2024-08-07 Thread Fujii Masao
On 2024/08/06 19:28, Junwang Zhao wrote: Attached v2 addressed all the problems you mentioned, thanks. Thanks for updating the patches! In the ALTER TABLE documentation, v1 patch updated the syntax, but the descriptions for MERGE and SPLIT should also be updated to explain the tablespace

Re: Support specify tablespace for each merged/split partition

2024-08-06 Thread Junwang Zhao
On Tue, Aug 6, 2024 at 5:34 PM Amul Sul wrote: > > On Mon, Aug 5, 2024 at 9:05 PM Junwang Zhao wrote: > > > > Hi Amul, > > > > Thanks for your review. > > > > On Mon, Aug 5, 2024 at 8:38 PM Amul Sul wrote: > > > > > > On Mon, Jul 15, 2024 at 11:19 AM Junwang Zhao wrote: > > > > > > >[...] > > >

Re: Support specify tablespace for each merged/split partition

2024-08-06 Thread Amul Sul
On Mon, Aug 5, 2024 at 9:05 PM Junwang Zhao wrote: > > Hi Amul, > > Thanks for your review. > > On Mon, Aug 5, 2024 at 8:38 PM Amul Sul wrote: > > > > On Mon, Jul 15, 2024 at 11:19 AM Junwang Zhao wrote: > > > > >[...] > > static Relation > > -createPartitionTable(RangeVar *newPartName, Relatio

Re: Support specify tablespace for each merged/split partition

2024-08-05 Thread Junwang Zhao
Hi Amul, Thanks for your review. On Mon, Aug 5, 2024 at 8:38 PM Amul Sul wrote: > > On Mon, Jul 15, 2024 at 11:19 AM Junwang Zhao wrote: > > > > In [1], it is suggested that it might be a good idea to support > > specifying the tablespace for each merged/split partition. > > > > We can do the f

Re: Support specify tablespace for each merged/split partition

2024-08-05 Thread Amul Sul
On Mon, Jul 15, 2024 at 11:19 AM Junwang Zhao wrote: > > In [1], it is suggested that it might be a good idea to support > specifying the tablespace for each merged/split partition. > > We can do the following after this feature is supported: > > CREATE TABLESPACE tblspc LOCATION '/tmp/tblspc'; >

Support specify tablespace for each merged/split partition

2024-07-14 Thread Junwang Zhao
In [1], it is suggested that it might be a good idea to support specifying the tablespace for each merged/split partition. We can do the following after this feature is supported: CREATE TABLESPACE tblspc LOCATION '/tmp/tblspc'; CREATE TABLE t (i int PRIMARY KEY) PARTITION BY RANGE (i); CREATE TA