Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-02-14 Thread Amul Sul
On Mon, Feb 14, 2022 at 3:07 PM Heikki Linnakangas wrote: > > On 28/01/2022 12:10, Amul Sul wrote: > > On Thu, Jan 27, 2022 at 12:01 PM Michael Paquier > > wrote: > >> > >> After reading this patch and this thread, I have noticed that you are > >> testing the same thing as Heikki here, patch

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-02-14 Thread Heikki Linnakangas
On 28/01/2022 12:10, Amul Sul wrote: On Thu, Jan 27, 2022 at 12:01 PM Michael Paquier wrote: After reading this patch and this thread, I have noticed that you are testing the same thing as Heikki here, patch 0001:

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-28 Thread Amul Sul
On Thu, Jan 27, 2022 at 12:01 PM Michael Paquier wrote: > > On Thu, Jan 20, 2022 at 12:13:08PM +0530, Amul Sul wrote: > > I found the cause for the test failing on window -- is due to the > > custom archive command setting which wasn't setting the correct window > > archive directory path. > >

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-26 Thread Kyotaro Horiguchi
At Thu, 27 Jan 2022 15:31:37 +0900, Michael Paquier wrote in > On Thu, Jan 20, 2022 at 12:13:08PM +0530, Amul Sul wrote: > > I found the cause for the test failing on window -- is due to the > > custom archive command setting which wasn't setting the correct window > > archive directory path. >

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-26 Thread Michael Paquier
On Thu, Jan 20, 2022 at 12:13:08PM +0530, Amul Sul wrote: > I found the cause for the test failing on window -- is due to the > custom archive command setting which wasn't setting the correct window > archive directory path. After reading this patch and this thread, I have noticed that you are

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-19 Thread Amul Sul
On Tue, Jan 18, 2022 at 10:31 AM Kyotaro Horiguchi wrote: > > At Tue, 18 Jan 2022 12:25:15 +0800, Julien Rouhaud wrote > in > > Hi, > > > > On Mon, Jan 17, 2022 at 09:33:57PM +0800, Julien Rouhaud wrote: > > > > > > Thanks for the updated patch! Note that thanks to Andres and Thomas > > >

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-17 Thread Kyotaro Horiguchi
At Tue, 18 Jan 2022 12:25:15 +0800, Julien Rouhaud wrote in > Hi, > > On Mon, Jan 17, 2022 at 09:33:57PM +0800, Julien Rouhaud wrote: > > > > Thanks for the updated patch! Note that thanks to Andres and Thomas work, > > you > > can now easily rely on the exact same CI than the cfbot on your

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-17 Thread Julien Rouhaud
Hi, On Mon, Jan 17, 2022 at 09:33:57PM +0800, Julien Rouhaud wrote: > > Thanks for the updated patch! Note that thanks to Andres and Thomas work, you > can now easily rely on the exact same CI than the cfbot on your own github > repository, if you need to debug something on a platform you don't

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-17 Thread Julien Rouhaud
Hi, On Mon, Jan 17, 2022 at 05:07:48PM +0530, Amul Sul wrote: > > I am not sure what really went wrong but I think the 'standby_9' > server shutdown too early before it gets a chance to archive a > required WAL file. The attached patch tries to shutdown that server > after the required WAL are

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-17 Thread Amul Sul
On Sat, Jan 15, 2022 at 11:35 AM Julien Rouhaud wrote: > > Hi, > > On Mon, Jan 10, 2022 at 09:46:23AM +0530, Amul Sul wrote: > > > > Thanks for the note, I can see the same test is failing on my centos > > vm too with the latest master head(376ce3e404b). The failing reason is > > the

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-14 Thread Julien Rouhaud
Hi, On Mon, Jan 10, 2022 at 09:46:23AM +0530, Amul Sul wrote: > > Thanks for the note, I can see the same test is failing on my centos > vm too with the latest master head(376ce3e404b). The failing reason is > the "recovery_target_inclusive = off" setting which is unnecessary for > this test,

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-09 Thread Amul Sul
On Mon, Jan 10, 2022 at 8:25 AM Andres Freund wrote: > > Hi, > > On 2021-11-23 11:43:21 +0530, Amul Sul wrote: > > Attached patch covers a case where TLI in the filename for a > > record being read is different from where it belongs to. In other > > words, it covers following case noted in

Re: TAP test to cover "EndOfLogTLI != replayTLI" case

2022-01-09 Thread Andres Freund
Hi, On 2021-11-23 11:43:21 +0530, Amul Sul wrote: > Attached patch covers a case where TLI in the filename for a > record being read is different from where it belongs to. In other > words, it covers following case noted in StartupXLOG(): > Thoughts? Suggestions? It seems the test isn't quite

TAP test to cover "EndOfLogTLI != replayTLI" case

2021-11-22 Thread Amul Sul
Hi, Attached patch covers a case where TLI in the filename for a record being read is different from where it belongs to. In other words, it covers following case noted in StartupXLOG(): /* * EndOfLogTLI is the TLI in the filename of the XLOG segment containing * the end-of-log. It could be