Re: TCP option assign hook doesn't work well if option not supported

2019-12-22 Thread Michael Paquier
On Thu, Dec 19, 2019 at 07:26:19PM +0100, Peter Eisentraut wrote: > macOS does not support the socket option TCP_USER_TIMEOUT. Yet, I can start > a server with postgres -D ... --tcp-user-timeout=100 without a diagnostic. > Only when I connect I get a log entry > > LOG: setsockopt(TCP_USER_TIMEOU

TCP option assign hook doesn't work well if option not supported

2019-12-19 Thread Peter Eisentraut
macOS does not support the socket option TCP_USER_TIMEOUT. Yet, I can start a server with postgres -D ... --tcp-user-timeout=100 without a diagnostic. Only when I connect I get a log entry LOG: setsockopt(TCP_USER_TIMEOUT) not supported Perhaps the logic in pq_settcpusertimeout() should be