Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-22 Thread Yugo NAGATA
On Sat, 19 Mar 2022 19:31:59 +0900 Michael Paquier wrote: > On Fri, Mar 18, 2022 at 03:13:05PM +0900, Michael Paquier wrote: > > Thanks. This looks rather sane to me. I'll split things into 3 > > commits in total, as of the psql completion, SET TABLESPACE and SET > > ACCESS METHOD. The first a

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-19 Thread Michael Paquier
On Fri, Mar 18, 2022 at 03:13:05PM +0900, Michael Paquier wrote: > Thanks. This looks rather sane to me. I'll split things into 3 > commits in total, as of the psql completion, SET TABLESPACE and SET > ACCESS METHOD. The first and third patches are only for HEAD, while > the documentation hole w

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-17 Thread Michael Paquier
On Fri, Mar 18, 2022 at 10:27:41AM +0900, Yugo NAGATA wrote: > I added some queries in the regression test. Attached is the updated patch. Thanks. This looks rather sane to me. I'll split things into 3 commits in total, as of the psql completion, SET TABLESPACE and SET ACCESS METHOD. The first

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-17 Thread Yugo NAGATA
Hi Michael-san, On Wed, 16 Mar 2022 16:18:09 +0900 Michael Paquier wrote: > Hi Nagata-san, > > On Wed, Mar 16, 2022 at 01:33:37PM +0900, Yugo NAGATA wrote: > > SET ACCESS METHOD is supported in ALTER TABLE since the commit > > b0483263dd. Since that time, this also has be allowed SET ACCESS >

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-16 Thread Michael Paquier
Hi Nagata-san, On Wed, Mar 16, 2022 at 01:33:37PM +0900, Yugo NAGATA wrote: > SET ACCESS METHOD is supported in ALTER TABLE since the commit > b0483263dd. Since that time, this also has be allowed SET ACCESS > METHOD in ALTER MATERIALIZED VIEW. Although it is not documented, > this works. Yes, t

Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-15 Thread Yugo NAGATA
Hello hackers, SET ACCESS METHOD is supported in ALTER TABLE since the commit b0483263dd. Since that time, this also has be allowed SET ACCESS METHOD in ALTER MATERIALIZED VIEW. Although it is not documented, this works. I cannot found any reasons to prohibit SET ACCESS METHOD in ALTER MATERIALI