On Mon, Sep 5, 2022 at 9:51 AM Nikita Malakhov wrote:
> Hi hackers!
>
> This is the original patch rebased onto v15 master with conflicts
> resolved. I'm currently
> studying it and latest comments in the original thread, and would try go
> the way that
> was mentioned in the thread (last message
mendations, I'll check that out.
On Mon, Sep 5, 2022 at 7:36 PM Justin Pryzby wrote:
> On Mon, Sep 05, 2022 at 05:38:51PM +0300, Nikita Malakhov wrote:
> > Due to experiments with columnar data storage I've decided to revive this
> > thread - Table AM modification
On Mon, Sep 05, 2022 at 05:38:51PM +0300, Nikita Malakhov wrote:
> Due to experiments with columnar data storage I've decided to revive this
> thread - Table AM modifications to accept column projection lists
> <https://www.postgresql.org/message-id/flat/cae-ml+9
Hi hackers!
Due to experiments with columnar data storage I've decided to revive this
thread -
Table AM modifications to accept column projection lists
<https://www.postgresql.org/message-id/flat/cae-ml+9rmtnzkcntzpqf8o3b-ujhwgfbsoxpqa3wvuc8ybb...@mail.gmail.com>
To remind:
On Thu, Jul 1, 2021 at 7:42 AM Jacob Champion wrote:
>
> Hi all,
>
> Ashwin, Deep, and I were discussing this patch today. We agree that
> it's fairly difficult to review in its current state, and the lack of a
> concrete implementation of the new API isn't helping. (A big chunk of
> the context f
Hi all,
Ashwin, Deep, and I were discussing this patch today. We agree that
it's fairly difficult to review in its current state, and the lack of a
concrete implementation of the new API isn't helping. (A big chunk of
the context for the patch exists in the zedstore megathread, which
isn't exactly
On Sat, 2021-06-05 at 09:47 -0700, Zhihong Yu wrote:
> On Fri, Jun 4, 2021 at 4:14 PM Jacob Champion wrote:
> > Agreed. I'm going to double-check with Deep that the new calls
> > to table_tuple_fetch_row_version() should be projecting the full row,
> > then post an updated patch some time next wee
On Fri, Jun 4, 2021 at 4:14 PM Jacob Champion wrote:
> On Tue, 2021-06-01 at 15:38 +0300, Aleksander Alekseev wrote:
> > I came across this patch and noticed that it rotted a little,
> > especially after removing inheritance_planner() in 86dc9005. I
> > managed to resolve the conflicts on current
On Tue, 2021-06-01 at 15:38 +0300, Aleksander Alekseev wrote:
> I came across this patch and noticed that it rotted a little,
> especially after removing inheritance_planner() in 86dc9005. I
> managed to resolve the conflicts on current `master` (eb89cb43), see
> the attached patch. The code compil
Hi Soumyadeep, Jacob,
> Thanks for the review!
I came across this patch and noticed that it rotted a little, especially
after removing inheritance_planner() in 86dc9005. I managed to resolve the
conflicts on current `master` (eb89cb43), see the attached patch. The code
compiles but doesn't pass t
On Tue, 2021-03-02 at 10:35 -0800, Zhihong Yu wrote:
> Hi,
Thanks for the review!
> + /* Make sure the the new slot is not dependent on the original tuple */
>
> There is duplicate 'the'.
Thanks, I'll add this for the next batch of updates.
> For neededColumnContextWalker(),
>
> + els
Hi,
+ /* Make sure the the new slot is not dependent on the original tuple */
There is duplicate 'the'.
For neededColumnContextWalker(),
+ else if(var->varattno == 0) {
I think the if following the else is not needed - I assume var->varattno
wouldn't be negative.
Similar comment for ex
On Mon, 2021-03-01 at 23:13 +, Jacob Champion wrote:
> On Mon, 2021-03-01 at 16:59 -0600, Justin Pryzby wrote:
> > Why is this removed ?
>
> Mm, both of those analyze.c changes seem suspect. Possibly a mismerge
> from the zedstore branch; let me double-check.
>
> > its (possessive) not it's (
On Mon, 2021-03-01 at 16:59 -0600, Justin Pryzby wrote:
> -
> pgstat_progress_update_param(PROGRESS_ANALYZE_CURRENT_CHILD_TABLE_RELID,
>
>
>
>
On Thu, Dec 31, 2020 at 01:02:24PM -0800, Soumyadeep Chakraborty wrote:
> Hey Masahiko,
>
> I added it to the Jan CF (https://commitfest.postgresql.org/31/2922/).
>
> PFA a rebased version against latest head.
Thanks for working on this.
-
pgstat_progress_update_param(PROGRESS_AN
Hi, Soumyadeep:
Happy New Year.
+typedef struct neededColumnContext
+{
+ Bitmapset **mask;
+ int n;
+ * n specifies the number of allowed entries in mask: we use
+ * it for bounds-checking in the walker above.
I think the code would be easier to read if the above comment is moved or
copied f
Hey Masahiko,
I added it to the Jan CF (https://commitfest.postgresql.org/31/2922/).
PFA a rebased version against latest head.
Regards,
Soumyadeep
From d033a0e3bceaf6e3f861e08363d4f170bc2a9fea Mon Sep 17 00:00:00 2001
From: Jacob Champion
Date: Mon, 9 Nov 2020 16:36:10 -0800
Subject: [PATCH v2
Hi Soumyadeep,
On Sat, Nov 14, 2020 at 3:02 AM Soumyadeep Chakraborty
wrote:
>
> Hello,
>
> This patch introduces a set of changes to the table AM APIs, making them
> accept a column projection list. That helps columnar table AMs, so that
> they don't need to fetch all columns from disk, but only
Hello,
This patch introduces a set of changes to the table AM APIs, making them
accept a column projection list. That helps columnar table AMs, so that
they don't need to fetch all columns from disk, but only the ones
actually needed.
The set of changes in this patch is not exhaustive -
there are
19 matches
Mail list logo
