Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-21 Thread Amit Kapila
On Wed, Aug 21, 2024 at 12:40 PM Heikki Linnakangas wrote: > > On 21/08/2024 09:25, Amit Kapila wrote: > >> > >> I think this patch makes sense. I'm not sure we've actually made any > >> promises on it, but it feels wrong that the slot's LSN might be advanced > >> past the LSN that's been has been

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-21 Thread Heikki Linnakangas
On 21/08/2024 09:25, Amit Kapila wrote: On Wed, Aug 21, 2024 at 2:25 AM Heikki Linnakangas wrote: On 14/08/2024 16:54, Arseny Sher wrote: On 8/13/24 06:35, Amit Kapila wrote: On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote: Sorry for the poor formatting of the message above, this should

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-20 Thread Amit Kapila
On Wed, Aug 21, 2024 at 2:25 AM Heikki Linnakangas wrote: > > On 14/08/2024 16:54, Arseny Sher wrote: > > On 8/13/24 06:35, Amit Kapila wrote: > >> On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote: > >>> > >>> Sorry for the poor formatting of the message above, this should be > >>> better: > >>>

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-20 Thread Heikki Linnakangas
On 14/08/2024 16:54, Arseny Sher wrote: On 8/13/24 06:35, Amit Kapila wrote: On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote: Sorry for the poor formatting of the message above, this should be better: Hey. Currently synchronous_commit is disabled for logical apply worker on the ground th

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-14 Thread Arseny Sher
On 8/13/24 06:35, Amit Kapila wrote: On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote: Sorry for the poor formatting of the message above, this should be better: Hey. Currently synchronous_commit is disabled for logical apply worker on the ground that reported flush_lsn includes only loca

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-12 Thread Amit Kapila
On Mon, Aug 12, 2024 at 3:43 PM Arseny Sher wrote: > > Sorry for the poor formatting of the message above, this should be better: > > Hey. Currently synchronous_commit is disabled for logical apply worker > on the ground that reported flush_lsn includes only locally flushed data > so slot (publish

Re: Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-12 Thread Arseny Sher
Sorry for the poor formatting of the message above, this should be better: Hey. Currently synchronous_commit is disabled for logical apply worker on the ground that reported flush_lsn includes only locally flushed data so slot (publisher) preserves everything higher than this, and so in case of s

Taking into account syncrep position in flush_lsn reported by apply worker

2024-08-12 Thread Arseny Sher
Hey. Currently synchronous_commit is by default disabled for logical apply worker on the ground that reported flush_lsn includes only locally flushed data so slot (publisher) preserves everything higher than this, and so in case of subscriber restart no data is lost. However, imagine that subsc