Re: Typo in misc_sanity.sql?

2022-08-10 Thread Peter Eisentraut
On 25.07.22 14:04, Japin Li wrote: Yeah, they do not have unique keys, however, here we check primary keys. So, IMO, the description exceptions should say they do not have primary keys, rather than do not have unique keys. The context of that check is that for each system catalog we pick one

Re: Typo in misc_sanity.sql?

2022-07-25 Thread Japin Li
On Mon, 25 Jul 2022 at 19:39, Tom Lane wrote: > Japin Li writes: >> I found the misc_sanity has a SQL to check system catalogs that >> do not have primary keys, however, in current exceptions it says >> pg_depend, pg_shdepend don't have a unique key. > > As indeed they do not: > > regression=#

Re: Typo in misc_sanity.sql?

2022-07-25 Thread Tom Lane
Japin Li writes: > I found the misc_sanity has a SQL to check system catalogs that > do not have primary keys, however, in current exceptions it says > pg_depend, pg_shdepend don't have a unique key. As indeed they do not: regression=# \d pg_depend Table "pg_catalog.pg_depend"

Re: Typo in misc_sanity.sql?

2022-07-25 Thread Bharath Rupireddy
On Mon, Jul 25, 2022 at 1:24 PM Japin Li wrote: > > > Hi, hackers > > I found the misc_sanity has a SQL to check system catalogs that > do not have primary keys, however, in current exceptions it says > pg_depend, pg_shdepend don't have a unique key. > > Should we fix it? Indeed. There's a clear

Typo in misc_sanity.sql?

2022-07-25 Thread Japin Li
Hi, hackers I found the misc_sanity has a SQL to check system catalogs that do not have primary keys, however, in current exceptions it says pg_depend, pg_shdepend don't have a unique key. Should we fix it? -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd. diff --git