Re: Typo in tablesync comment

2021-02-03 Thread Michael Paquier
On Thu, Feb 04, 2021 at 10:50:11AM +1100, Peter Smith wrote: > OK. I attached an updated patch using this new text. Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: Typo in tablesync comment

2021-02-03 Thread Peter Smith
On Wed, Feb 3, 2021 at 11:55 PM Amit Kapila wrote: > > On Wed, Feb 3, 2021 at 1:35 PM Michael Paquier wrote: > > > > On Wed, Feb 03, 2021 at 06:52:56PM +1100, Peter Smith wrote: > > > > > Maybe better to rewrite it more drastically? > > > > > > e.g > > > - > > > *The catalog pg_subscript

Re: Typo in tablesync comment

2021-02-03 Thread Amit Kapila
On Wed, Feb 3, 2021 at 1:35 PM Michael Paquier wrote: > > On Wed, Feb 03, 2021 at 06:52:56PM +1100, Peter Smith wrote: > > > Maybe better to rewrite it more drastically? > > > > e.g > > - > > *The catalog pg_subscription_rel is used to keep information about > > *subscribed tables an

Re: Typo in tablesync comment

2021-02-03 Thread Michael Paquier
On Wed, Feb 03, 2021 at 06:52:56PM +1100, Peter Smith wrote: > OTOH I thought "additionally stored" made it seem like those states > were in the catalog and "additionally" in shared memory. Good point. > Maybe better to rewrite it more drastically? > > e.g > - > *The catalog pg_subscrip

Re: Typo in tablesync comment

2021-02-02 Thread Peter Smith
On Wed, Feb 3, 2021 at 6:13 PM Michael Paquier wrote: > > On Tue, Feb 02, 2021 at 07:23:37PM +0530, Amit Kapila wrote: > > I don't mind changing to your proposed text but I think the current > > wording is also okay and seems clear to me. > > Reading that again, I still find the word "transient" t

Re: Typo in tablesync comment

2021-02-02 Thread Michael Paquier
On Tue, Feb 02, 2021 at 07:23:37PM +0530, Amit Kapila wrote: > I don't mind changing to your proposed text but I think the current > wording is also okay and seems clear to me. Reading that again, I still find the word "transient" to be misleading in this context. Any extra opinions? -- Michael

Re: Typo in tablesync comment

2021-02-02 Thread Amit Kapila
On Tue, Feb 2, 2021 at 10:49 AM Michael Paquier wrote: > > On Tue, Feb 02, 2021 at 10:38:31AM +1100, Peter Smith wrote: > > PSA a trivial patch to correct what seems like a typo in the tablesync > > comment. > > - * subscribed tables and their state. Some transient state during data > - *

Re: Typo in tablesync comment

2021-02-02 Thread Euler Taveira
On Tue, Feb 2, 2021, at 2:19 AM, Michael Paquier wrote: > On Tue, Feb 02, 2021 at 10:38:31AM +1100, Peter Smith wrote: > > PSA a trivial patch to correct what seems like a typo in the tablesync > > comment. > > - * subscribed tables and their state. Some transient state during data > - *

Re: Typo in tablesync comment

2021-02-01 Thread Michael Paquier
On Tue, Feb 02, 2021 at 10:38:31AM +1100, Peter Smith wrote: > PSA a trivial patch to correct what seems like a typo in the tablesync > comment. - * subscribed tables and their state. Some transient state during data - * synchronization is kept in shared memory. The states SYNCWAIT

Typo in tablesync comment

2021-02-01 Thread Peter Smith
PSA a trivial patch to correct what seems like a typo in the tablesync comment. Kind Regards, Peter Smith. Fujitsu Australia fix-tablesync-comment-typo-20210202.patch Description: Binary data