At Thu, 14 Mar 2024 11:23:38 +0530, Amit Kapila wrote
in
> On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
> wrote:
> >
> > While examining reorderbuffer.c, I found several typos. I'm not sure
> > if fixing them is worthwhile, but I've attached a fix just in case.
> >
>
> LGTM. I'll push thi
On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
wrote:
>
> While examining reorderbuffer.c, I found several typos. I'm not sure
> if fixing them is worthwhile, but I've attached a fix just in case.
>
LGTM. I'll push this in some time.
--
With Regards,
Amit Kapila.
Hello.
While examining reorderbuffer.c, I found several typos. I'm not sure
if fixing them is worthwhile, but I've attached a fix just in case.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/lo
On Thu, Oct 8, 2020 at 2:40 PM Masahiko Sawada
wrote:
>
> On Thu, 8 Oct 2020 at 17:37, Amit Kapila wrote:
> >
>
> > So, I feel the
> > comments should be accordingly updated.
>
> +1 for this change.
>
Thanks, I have pushed this and along with it pushed a typo-fix in logical.c.
--
With Regards,
On Thu, 8 Oct 2020 at 17:37, Amit Kapila wrote:
>
> @@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb,
> ReorderBufferTXN *txn)
> ReorderBufferCleanupTXN(rb, subtxn);
> }
>
> - /* cleanup changes in the toplevel txn */
> + /* cleanup changes in the txn */
> dlist_foreach_modify
@@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb,
ReorderBufferTXN *txn)
ReorderBufferCleanupTXN(rb, subtxn);
}
- /* cleanup changes in the toplevel txn */
+ /* cleanup changes in the txn */
dlist_foreach_modify(iter, &txn->changes)
{
ReorderBufferChange *change;
@@ -1533,
