Re: Unportable code in autoprewarm.c

2018-05-02 Thread Robert Haas
On Wed, May 2, 2018 at 3:21 PM, Tom Lane wrote: > Is there a reason why this record count needs to be int64 rather than > plain int, and if so what? This code is not exactly well documented, > but it looks to me like the number of records should be bounded by > NBuffers,

Unportable code in autoprewarm.c

2018-05-02 Thread Tom Lane
I've been going through compiler warnings from the buildfarm, and I notice jacana is unhappy about this: /* First line of the file is a record count. */ if (fscanf(file, "<<" INT64_FORMAT ">>\n", _elements) != 1) It's entirely correct to complain, because we only guarantee that