Re: Unstable regression test for contrib/pageinspect

2022-11-20 Thread Tom Lane
Peter Geoghegan writes: > On Sun, Nov 20, 2022 at 12:37 PM Tom Lane wrote: >> The core reloptions.sql and vacuum.sql tests are two places that are >> also using this option, but they are applying it to temp tables, >> which I think makes it safe (and the lack of failures, seeing that >> they run

Re: Unstable regression test for contrib/pageinspect

2022-11-20 Thread Tom Lane
Mark Dilger writes: > On Nov 20, 2022, at 12:37 PM, Tom Lane wrote: >> contrib/amcheck and contrib/pg_visibility are also using >> DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards. >> I haven't seen them fall over, though. > In the amcheck regression test case, it's because the te

Re: Unstable regression test for contrib/pageinspect

2022-11-20 Thread Mark Dilger
> On Nov 20, 2022, at 12:37 PM, Tom Lane wrote: > > contrib/amcheck and contrib/pg_visibility are also using > DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards. > I haven't seen them fall over, though. In the amcheck regression test case, it's because the test isn't sensitive t

Re: Unstable regression test for contrib/pageinspect

2022-11-20 Thread Peter Geoghegan
On Sun, Nov 20, 2022 at 12:37 PM Tom Lane wrote: > The core reloptions.sql and vacuum.sql tests are two places that are > also using this option, but they are applying it to temp tables, > which I think makes it safe (and the lack of failures, seeing that > they run within parallel test groups, re

Unstable regression test for contrib/pageinspect

2022-11-20 Thread Tom Lane
My very slow buildfarm animal mamba has failed pageinspect several times [1][2][3][4] with this symptom: diff -U3 /home/buildfarm/bf-data/HEAD/pgsql.build/contrib/pageinspect/expected/page.out /home/buildfarm/bf-data/HEAD/pgsql.build/contrib/pageinspect/results/page.out --- /home/buildfarm/bf-d