On Thu, 13 Sep 2018 17:03:28 +0900
Michael Paquier wrote:
> On Thu, Sep 13, 2018 at 03:47:26PM +0900, Tatsuo Ishii wrote:
> > Anyway, considering it's a static function, chance of breaking
> > backward compatibility is minimum, I think.
> >
> > So +1 to remove the unused argument.
>
> Same
On Thu, Sep 13, 2018 at 03:47:26PM +0900, Tatsuo Ishii wrote:
> Anyway, considering it's a static function, chance of breaking
> backward compatibility is minimum, I think.
>
> So +1 to remove the unused argument.
Same opinion and arguments here, so I have committed the patch.
--
Michael
> Hi,
>
> I found that a argument "filename" is not used in execute_sql_string()
> although the comment says "filename is used only to report errors.",
> so I think we can remove this argument as done in the patch I attached.
It seems the "filename" argument has been there since the first
Hi,
I found that a argument "filename" is not used in execute_sql_string()
although the comment says "filename is used only to report errors.",
so I think we can remove this argument as done in the patch I attached.
Regards,
--
Yugo Nagata
diff --git a/src/backend/commands/extension.c
