Re: Use proc instead of MyProc in ProcArrayGroupClearXid()/TransactionGroupUpdateXidStatus()

2022-11-08 Thread Bharath Rupireddy
On Tue, Nov 8, 2022 at 11:59 AM Amit Kapila wrote: > > On Mon, Nov 7, 2022 at 3:17 PM rajesh singarapu > wrote: > > > > In both TransactionGroupUpdateXidStatus and ProcArrayGroupClearXid > > global MyProc is used. for consistency, replaced with a function local > > variable. > > > > In ProcArra

Re: Use proc instead of MyProc in ProcArrayGroupClearXid()/TransactionGroupUpdateXidStatus()

2022-11-07 Thread rajesh singarapu
Thanks Bharat and Amit for the review and explaining rationale. for the TransactionGroupUpdateXidStatus() change, let me see if I can piggy back this change on something more valuable. thanks Rajesh On Tue, Nov 8, 2022 at 11:58 AM Amit Kapila wrote: > > On Mon, Nov 7, 2022 at 3:17 PM rajesh si

Re: Use proc instead of MyProc in ProcArrayGroupClearXid()/TransactionGroupUpdateXidStatus()

2022-11-07 Thread Amit Kapila
On Mon, Nov 7, 2022 at 3:17 PM rajesh singarapu wrote: > > In both TransactionGroupUpdateXidStatus and ProcArrayGroupClearXid > global MyProc is used. for consistency, replaced with a function local > variable. > In ProcArrayGroupClearXid(), currently, we always pass MyProc as proc, so the chang

Re: Use proc instead of MyProc in ProcArrayGroupClearXid()/TransactionGroupUpdateXidStatus()

2022-11-07 Thread Bharath Rupireddy
On Mon, Nov 7, 2022 at 3:17 PM rajesh singarapu wrote: > > Hi, > > In both TransactionGroupUpdateXidStatus and ProcArrayGroupClearXid > global MyProc is used. for consistency, replaced with a function local > variable. if (nextproc != MyProc) PGSemaphoreUnlock(nextproc->sem);

Use proc instead of MyProc in ProcArrayGroupClearXid()/TransactionGroupUpdateXidStatus()

2022-11-07 Thread rajesh singarapu
Hi, In both TransactionGroupUpdateXidStatus and ProcArrayGroupClearXid global MyProc is used. for consistency, replaced with a function local variable. thanks Rajesh v1-0001-Use-proc-instead-of-MyProc-in-ProcArrayGroupClear.patch Description: Binary data