Re: WIP: Generic functions for Node types using generated metadata

2020-06-09 Thread David Rowley
On Fri, 20 Sep 2019 at 17:19, Andres Freund wrote: > 3) WIP: Improve and expand stringinfo.[ch]. > >Expands the set of functions exposed, to allow appending various >numeric types etc. Also improve efficiency by moving code to inline >functions - that's beneficial because the size is

Re: WIP: Generic functions for Node types using generated metadata

2019-10-03 Thread Robert Haas
On Wed, Oct 2, 2019 at 4:46 PM Andres Freund wrote: > > The existing expectation is that we make our build tools in Perl. > > I'm sure Andres doesn't want to write a C parser in Perl, but > > poking around suggests that there are multiple options already > > available in CPAN. I'd much rather

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Andres Freund
Hi, On 2019-10-02 14:47:22 -0400, Tom Lane wrote: > Robert Haas writes: > > On Wed, Oct 2, 2019 at 12:03 PM Tom Lane wrote: > >> I'm afraid that's going to be a deal-breaker for lots of people. > >> It's fine for prototyping the idea but we'll need to find another > >> implementation before we

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Andres Freund
Hi, On 2019-10-02 14:30:08 -0400, Robert Haas wrote: > On Wed, Oct 2, 2019 at 12:03 PM Tom Lane wrote: > > I'm afraid that's going to be a deal-breaker for lots of people. > > It's fine for prototyping the idea but we'll need to find another > > implementation before we can move to commit. > >

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Tom Lane
Robert Haas writes: > On Wed, Oct 2, 2019 at 12:03 PM Tom Lane wrote: >> I'm afraid that's going to be a deal-breaker for lots of people. >> It's fine for prototyping the idea but we'll need to find another >> implementation before we can move to commit. > Why do you think it will be a

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Robert Haas
On Wed, Oct 2, 2019 at 12:03 PM Tom Lane wrote: > I'm afraid that's going to be a deal-breaker for lots of people. > It's fine for prototyping the idea but we'll need to find another > implementation before we can move to commit. Why do you think it will be a deal-breaker for lots of people? I

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Tom Lane
Robert Haas writes: > It seems like the approach Andres is proposing here could work pretty > well. I think the biggest possible problem is that any semi-serious > developer will basically have to have LLVM installed. To build the > software, you wouldn't need LLVM unless you want to build with

Re: WIP: Generic functions for Node types using generated metadata

2019-10-02 Thread Robert Haas
On Fri, Aug 30, 2019 at 9:03 AM Fabien COELHO wrote: > I have found this thread: > > https://www.postgresql.org/message-id/flat/E1cq93r-0004ey-Mp%40gemulon.postgresql.org > > It seems that comments from committers discouraged me to go on… :-) For > instance Robert wanted a "checker", which is

Re: WIP: Generic functions for Node types using generated metadata

2019-09-21 Thread David Fetter
On Fri, Sep 20, 2019 at 03:43:54PM -0700, Andres Freund wrote: > Hi, > > On 2019-09-19 22:18:57 -0700, Andres Freund wrote: > > While working on this I evolved the node string format a bit: > > > > 1) Node types start with the their "normal" name, rather than > >uppercase. There seems little

Re: WIP: Generic functions for Node types using generated metadata

2019-08-30 Thread Fabien COELHO
Hallo Andres, There've been various calls for automating their generation, but no actual patches that I am aware of. I started something a while back I have found this thread: https://www.postgresql.org/message-id/flat/E1cq93r-0004ey-Mp%40gemulon.postgresql.org It seems that comments

Re: WIP: Generic functions for Node types using generated metadata

2019-08-30 Thread Fabien COELHO
Hello Andres, Just my 0.02 €: There's been a lot of complaints over the years about how annoying it is to keep the out/read/copy/equalfuncs.c functions in sync with the actual underlying structs. There've been various calls for automating their generation, but no actual patches that I am