Re: When to drop src/tools/msvc support

On 08.04.23 21:10, Andres Freund wrote: Do we want to drop src/tools/msvc support in 16 (i.e. now), or do it early in 17? Can you build using meson from a distribution tarball on Windows?

Re: When to drop src/tools/msvc support

Hi, On 2023-04-11 19:44:20 +0200, Alvaro Herrera wrote: > On 2023-Apr-11, Michael Paquier wrote: > > > Getting a CI job able to do some validation for MSVC would be indeed > > nice. What's the plan in the buildfarm with this coverage? Would all > > the animals switch to meson (Chocolatey +

Re: When to drop src/tools/msvc support

On 2023-Apr-11, Michael Paquier wrote: > Getting a CI job able to do some validation for MSVC would be indeed > nice. What's the plan in the buildfarm with this coverage? Would all > the animals switch to meson (Chocolatey + StrawberryPerl, I assume) > for the job or will there still be some

Re: When to drop src/tools/msvc support

Andres Freund writes: > Except that we're planning to remove it anyway, the structure of the docs here > seems a bit off... Indeed. We'll have to migrate some of that info elsewhere when the time comes. regards, tom lane

Re: When to drop src/tools/msvc support

Hi, On 2023-04-11 13:30:15 -0400, Tom Lane wrote: > Andres Freund writes: > > Here's a draft docs change. > > > I added the in two places in install-windows.sgml so it's visible > > on both the generated pages in the chunked output. That does mean it's > > visible > > twice nearby in the

Re: When to drop src/tools/msvc support

Andres Freund writes: > Here's a draft docs change. > I added the in two places in install-windows.sgml so it's visible > on both the generated pages in the chunked output. That does mean it's visible > twice nearby in the single-page output, but I don't think that's commonly > used. I don't

Re: When to drop src/tools/msvc support

Hi, On 2023-04-11 10:44:09 -0400, Jonathan S. Katz wrote: > On 4/11/23 10:12 AM, Tom Lane wrote: > > "Jonathan S. Katz" writes: > > > On 4/11/23 9:49 AM, Tom Lane wrote: > > > > Sadly, I think we really have to ship both build systems in v16. > > > > > But maybe we can make it clear in the

Re: When to drop src/tools/msvc support

Hi, On 2023-04-11 09:05:31 +0100, Dave Page wrote: > Probably my main concern is that the Meson build can use the same version > of the VC++ compiler that we use (v14), which is carefully matched for > compatibility with all the various components, just in case anything passes > CRT pointers

Re: When to drop src/tools/msvc support

On 4/11/23 10:12 AM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/11/23 9:49 AM, Tom Lane wrote: Sadly, I think we really have to ship both build systems in v16. But maybe we can make it clear in the release notes + docs that this is slated for deprecation and will be removed from v17?

Re: When to drop src/tools/msvc support

"Jonathan S. Katz" writes: > On 4/11/23 9:49 AM, Tom Lane wrote: >> Sadly, I think we really have to ship both build systems in v16. > But maybe we can make it clear in the release notes + docs that this is > slated for deprecation and will be removed from v17? That way we can say > "we

Re: When to drop src/tools/msvc support

On 4/11/23 9:49 AM, Tom Lane wrote: Dave Page writes: On Tue, 11 Apr 2023 at 13:52, Jonathan S. Katz wrote: Do you think we'll have enough info by end of this week to make a decision on whether we can drop MSVC in v16? There's no way I can test anything this week - I'm on leave for most

Re: When to drop src/tools/msvc support

Dave Page writes: > On Tue, 11 Apr 2023 at 13:52, Jonathan S. Katz wrote: >> Do you think we'll have enough info by end of this week to make a >> decision on whether we can drop MSVC in v16? > There's no way I can test anything this week - I'm on leave for most of it > and AFK. > But, my point

Re: When to drop src/tools/msvc support

On Tue, 11 Apr 2023 at 13:52, Jonathan S. Katz wrote: > On 4/11/23 7:54 AM, Dave Page wrote: > > > > > > On Tue, 11 Apr 2023 at 11:58, Andrew Dunstan > > wrote: > > > > For meson you just need to to "pip install meson ninja" in your > > python distro and you

Re: When to drop src/tools/msvc support

On 4/11/23 7:54 AM, Dave Page wrote: On Tue, 11 Apr 2023 at 11:58, Andrew Dunstan > wrote: For meson you just need to to "pip install meson ninja" in your python distro and you should be good to go (they will be installed in python's Scripts

Re: When to drop src/tools/msvc support

On Tue, 11 Apr 2023 at 11:58, Andrew Dunstan wrote: > > On 2023-04-11 Tu 04:05, Dave Page wrote: > > > > On Tue, 11 Apr 2023 at 08:09, Magnus Hagander wrote: > >> On Tue, Apr 11, 2023 at 12:27 AM Andres Freund >> wrote: >> > >> > Hi, >> > >> > On 2023-04-10 19:55:35 +0100, Dave Page wrote: >>

Re: When to drop src/tools/msvc support

On 2023-04-11 Tu 04:05, Dave Page wrote: On Tue, 11 Apr 2023 at 08:09, Magnus Hagander wrote: On Tue, Apr 11, 2023 at 12:27 AM Andres Freund wrote: > > Hi, > > On 2023-04-10 19:55:35 +0100, Dave Page wrote: > > Projects other than the EDB installers use the MSVC

Re: When to drop src/tools/msvc support

On Tue, 11 Apr 2023 at 08:09, Magnus Hagander wrote: > On Tue, Apr 11, 2023 at 12:27 AM Andres Freund wrote: > > > > Hi, > > > > On 2023-04-10 19:55:35 +0100, Dave Page wrote: > > > Projects other than the EDB installers use the MSVC build system - e.g. > > > pgAdmin uses it’s own builds of

Re: When to drop src/tools/msvc support

On Tue, Apr 11, 2023 at 12:27 AM Andres Freund wrote: > > Hi, > > On 2023-04-10 19:55:35 +0100, Dave Page wrote: > > Projects other than the EDB installers use the MSVC build system - e.g. > > pgAdmin uses it’s own builds of libpq and other tools (psql, pg_dump etc) > > that are pretty heavily

Re: When to drop src/tools/msvc support

On 4/10/23 4:50 PM, Tom Lane wrote: Magnus Hagander writes: Thus, +1 on actually keeping it up and dropping it immediately as v17 opens, giving them a year of advantage. And probably updating the docs (if anybody were to read them.. but at least then we tried) stating that it's deprecated and

Re: When to drop src/tools/msvc support

On Mon, Apr 10, 2023 at 03:32:19PM -0700, Andres Freund wrote: > On IM Thomas made some point about CI - I wonder if we should add building 16 > with src/tools/msvc as an optional CI task? We can't enable it by default > (yet), because we'd not have enough resources to also run that for cfbot.

Re: When to drop src/tools/msvc support

Hi, On 2023-04-10 16:50:20 -0400, Tom Lane wrote: > Yeah, I think that's the only feasible answer at this point. > Maybe a month or two back we could have done differently, > but there's not a lot of runway now. > > Once we do drop src/tools/msvc from HEAD, we should make a point > of reminding

Re: When to drop src/tools/msvc support

Hi, On 2023-04-10 19:55:35 +0100, Dave Page wrote: > Projects other than the EDB installers use the MSVC build system - e.g. > pgAdmin uses it’s own builds of libpq and other tools (psql, pg_dump etc) > that are pretty heavily baked into a fully automated build system (even the > build servers

Re: When to drop src/tools/msvc support

Magnus Hagander writes: > Thus, +1 on actually keeping it up and dropping it immediately as v17 > opens, giving them a year of advantage. And probably updating the docs > (if anybody were to read them.. but at least then we tried) stating > that it's deprecated and will be removed in v17. Yeah,

Re: When to drop src/tools/msvc support

On Mon, Apr 10, 2023 at 6:56 PM Tom Lane wrote: > > Robert Haas writes: > > However, if this is the direction we're going, we probably need to > > give pgsql-packagers a heads up ASAP, because anybody who is still > > relying on the MSVC system to build Windows binaries is presumably > > going

Re: When to drop src/tools/msvc support

On Mon, 10 Apr 2023 at 18:34, Robert Haas wrote: > On Mon, Apr 10, 2023 at 12:56 PM Tom Lane wrote: > > Robert Haas writes: > > > However, if this is the direction we're going, we probably need to > > > give pgsql-packagers a heads up ASAP, because anybody who is still > > > relying on the

Re: When to drop src/tools/msvc support

On Mon, Apr 10, 2023 at 12:56 PM Tom Lane wrote: > Robert Haas writes: > > However, if this is the direction we're going, we probably need to > > give pgsql-packagers a heads up ASAP, because anybody who is still > > relying on the MSVC system to build Windows binaries is presumably > > going to

Re: When to drop src/tools/msvc support

Robert Haas writes: > However, if this is the direction we're going, we probably need to > give pgsql-packagers a heads up ASAP, because anybody who is still > relying on the MSVC system to build Windows binaries is presumably > going to need some time to adjust. If we rip out the build system >

Re: When to drop src/tools/msvc support

On Sat, Apr 8, 2023 at 3:30 PM Tom Lane wrote: > I guess I'd vote for pulling the trigger in v16 if we can get that > done by the end of April. Once we're close to beta I think it > must wait for v17 to open. I think that sounds reasonable. It would be to the project's advantage not to have to

Re: When to drop src/tools/msvc support

Andres Freund writes: > Do we want to drop src/tools/msvc support in 16 (i.e. now), or do it early in > 17? On the one hand, it feels like something we shouldn't do after feature freeze. On the other hand, continuing to maintain three build systems is a real drag (although you could argue that

Re: When to drop src/tools/msvc support

On 4/8/23 3:10 PM, Andres Freund wrote: Hi, I'd planned to write this soon anyway, but it was just brought up in [1]. Originally we had planned to drop src/tools/msvc support shortly after meson went in. Unfortunately, it took a bit longer than originally hoped for to merge meson support and

When to drop src/tools/msvc support

Hi, I'd planned to write this soon anyway, but it was just brought up in [1]. Originally we had planned to drop src/tools/msvc support shortly after meson went in. Unfortunately, it took a bit longer than originally hoped for to merge meson support and then longer than hoped to add buildfarm