Re: Where is SSPI auth username determined for TAP tests?

2019-07-03 Thread Michael Paquier
On Wed, Jul 03, 2019 at 09:53:14AM -0400, Tom Lane wrote: > I haven't checked that this actually works, but it looks plausible, > and I agree it's simpler/easier. Thanks, committed. While testing on Windows, I have been trapped by the fact that IPC::Run mishandles double quotes, causing the

Re: Where is SSPI auth username determined for TAP tests?

2019-07-03 Thread Tom Lane
Michael Paquier writes: > I have been reviewing that part, and the part to split the bootstrap > user from the set of extra roles created looks fine to me. Now, it > seems to me that you can simplify 010_dump_connstr.pl as per the > attached because PostgresNode::Init can take care of

Re: Where is SSPI auth username determined for TAP tests?

2019-07-03 Thread Michael Paquier
On Sun, Jun 30, 2019 at 12:09:18PM -0400, Tom Lane wrote: > We could apply the same hack on the source node, but I wonder if it > wouldn't be better to make this less of a kluge. I'm tempted to > propose that "pg_regress --config-auth --user XXX" should understand > XXX as the bootstrap superuser

Re: Where is SSPI auth username determined for TAP tests?

2019-06-30 Thread Tom Lane
Michael Paquier writes: > On Sat, Jun 29, 2019 at 04:36:51PM -0400, Tom Lane wrote: >> I think this is likely a consequence of ca129e58c0 having modified >> 010_dump_connstr.pl to use "regress_postgres" not "postgres" as the >> bootstrap superuser name in the source cluster. I suppose I

Re: Where is SSPI auth username determined for TAP tests?

2019-06-29 Thread Michael Paquier
On Sat, Jun 29, 2019 at 04:36:51PM -0400, Tom Lane wrote: > I think this is likely a consequence of ca129e58c0 having modified > 010_dump_connstr.pl to use "regress_postgres" not "postgres" as the > bootstrap superuser name in the source cluster. I suppose I overlooked > some dependency on the

Where is SSPI auth username determined for TAP tests?

2019-06-29 Thread Tom Lane
bowerbird is failing the pg_dump regression tests with a lot of FATAL: SSPI authentication failed for user "regress_postgres" I think this is likely a consequence of ca129e58c0 having modified 010_dump_connstr.pl to use "regress_postgres" not "postgres" as the bootstrap superuser name in the