Re: Why does pg_bsd_indent need to be installed?

2023-06-21 Thread Bruce Momjian
On Tue, Jun 20, 2023 at 06:54:56PM +0200, Álvaro Herrera wrote: > On 2023-May-31, Bruce Momjian wrote: > > > I guess we could try looking for pg_bsd_indent-$MAJOR_VERSION first, > > then pg_bsd_indent. > > Do you mean with $MAJOR_VERSION being Postgres' version? That means we > need to install a

Re: Why does pg_bsd_indent need to be installed?

2023-06-20 Thread Tom Lane
Alvaro Herrera writes: > Do you mean with $MAJOR_VERSION being Postgres' version? That means we > need to install a new symlink every year, even when pg_bsd_indent > doesn't change. I'd rather have it call pg_bsd_indent-$INDENT_VERSION > first, and pg_bsd_indent if that doesn't exist. I already

Re: Why does pg_bsd_indent need to be installed?

2023-06-20 Thread Alvaro Herrera
On 2023-May-31, Bruce Momjian wrote: > I guess we could try looking for pg_bsd_indent-$MAJOR_VERSION first, > then pg_bsd_indent. Do you mean with $MAJOR_VERSION being Postgres' version? That means we need to install a new symlink every year, even when pg_bsd_indent doesn't change. I'd rather h

Re: Why does pg_bsd_indent need to be installed?

2023-05-31 Thread Bruce Momjian
On Wed, May 31, 2023 at 01:21:05PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 25.05.23 13:05, Tom Lane wrote: > >> Well, if you know where the build directory is, sure. But any way you > >> slice it there is an extra bit of knowledge required. Since pg_bsd_indent > >> changes so se

Re: Why does pg_bsd_indent need to be installed?

2023-05-31 Thread Tom Lane
Peter Eisentraut writes: > On 25.05.23 13:05, Tom Lane wrote: >> Well, if you know where the build directory is, sure. But any way you >> slice it there is an extra bit of knowledge required. Since pg_bsd_indent >> changes so seldom, keeping it in your PATH is at least as easy as any >> other so

Re: Why does pg_bsd_indent need to be installed?

2023-05-31 Thread Peter Eisentraut
On 25.05.23 13:05, Tom Lane wrote: Well, if you know where the build directory is, sure. But any way you slice it there is an extra bit of knowledge required. Since pg_bsd_indent changes so seldom, keeping it in your PATH is at least as easy as any other solution, IMO. The reason I bumped int

Re: Why does pg_bsd_indent need to be installed?

2023-05-27 Thread Andres Freund
Hi, On 2023-05-25 13:05:57 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-05-25 09:09:45 -0400, Tom Lane wrote: > >> Peter Eisentraut writes: > >>> Why does pgindent require that pg_bsd_indent be installed in the path? > > > Isn't the situation actually *easier* in VPATH builds? Ther

Re: Why does pg_bsd_indent need to be installed?

2023-05-25 Thread Tom Lane
Andres Freund writes: > On 2023-05-25 09:09:45 -0400, Tom Lane wrote: >> Peter Eisentraut writes: >>> Why does pgindent require that pg_bsd_indent be installed in the path? > Isn't the situation actually *easier* in VPATH builds? There's no build > artifacts in the source tree, so you can just

Re: Why does pg_bsd_indent need to be installed?

2023-05-25 Thread Andres Freund
Hi, On 2023-05-25 09:09:45 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > Why does pgindent require that pg_bsd_indent be installed in the path? > > Couldn't pgindent call the pg_bsd_indent built inside the tree? That > > would make the whole process much smoother. > > Well, the curren

Re: Why does pg_bsd_indent need to be installed?

2023-05-25 Thread Tom Lane
Peter Eisentraut writes: > Why does pgindent require that pg_bsd_indent be installed in the path? > Couldn't pgindent call the pg_bsd_indent built inside the tree? That > would make the whole process much smoother. Well, the current expectation is that you run it in a distclean'd tree, in whic

Why does pg_bsd_indent need to be installed?

2023-05-25 Thread Peter Eisentraut
Why does pgindent require that pg_bsd_indent be installed in the path? Couldn't pgindent call the pg_bsd_indent built inside the tree? That would make the whole process much smoother.