Re: Yet another fast GiST build (typo)

> 7 сент. 2020 г., в 12:14, Andrey M. Borodin написал(а): > > Maybe I'm missing something? Like forgot to log 10% of pages, or something > like that... Indeed, there was a bug. I've fixed it, and I still observe same performance gain. Best regards, Andrey Borodin. v2-0001-nbtree-faster-l

Re: Yet another fast GiST build (typo)

> 6 сент. 2020 г., в 18:26, Heikki Linnakangas написал(а): > > On 05/09/2020 14:53, Andrey M. Borodin wrote: >> Thanks for ideas, Heikki. Please see v13 with proposed changes. > > Thanks, that was quick! > >> But I've found out that logging page-by-page slows down GiST build by >> approximate

Re: Yet another fast GiST build (typo)

> 6 сент. 2020 г., в 18:26, Heikki Linnakangas написал(а): > > On 05/09/2020 14:53, Andrey M. Borodin wrote: >> Thanks for ideas, Heikki. Please see v13 with proposed changes. > > Thanks, that was quick! > >> But I've found out that logging page-by-page slows down GiST build by >> approximate

Re: Yet another fast GiST build (typo)

On 05/09/2020 14:53, Andrey M. Borodin wrote: Thanks for ideas, Heikki. Please see v13 with proposed changes. Thanks, that was quick! But I've found out that logging page-by-page slows down GiST build by approximately 15% (when CPU constrained). Though In think that this is IO-wise. Hmm, any

Re: Yet another fast GiST build (typo)

> 3 сент. 2020 г., в 23:40, Heikki Linnakangas написал(а): > > On 30/08/2020 15:04, Andrey M. Borodin wrote: >>> 23 авг. 2020 г., в 14:39, Andrey M. Borodin >>> написал(а): >>> >>> Thanks for reviewing and benchmarking, Pavel! >> Pavel sent me few typos offlist. PFA v12 fixing these typos. >

Re: Yet another fast GiST build (typo)

On 30/08/2020 15:04, Andrey M. Borodin wrote: 23 авг. 2020 г., в 14:39, Andrey M. Borodin написал(а): Thanks for reviewing and benchmarking, Pavel! Pavel sent me few typos offlist. PFA v12 fixing these typos. In gist_indexsortbuild(), you first build all the leaf pages. Then, you read thro

Re: Yet another fast GiST build (typo)

> > Pavel sent me few typos offlist. PFA v12 fixing these typos. > Thanks! > Now I consider the patch ready to be committed and mark it so on CF. Thank you! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com

Re: Yet another fast GiST build (typo)

> 23 авг. 2020 г., в 14:39, Andrey M. Borodin написал(а): > > Thanks for reviewing and benchmarking, Pavel! Pavel sent me few typos offlist. PFA v12 fixing these typos. Thanks! Best regards, Andrey Borodin. v12-0001-Add-sort-support-for-point-gist_point_sortsuppor.patch Description: Binary

Re: Yet another fast GiST build (typo)

> 14 авг. 2020 г., в 14:21, Pavel Borisov написал(а): > > I see this feature quite useful in concept and decided to test it. Thanks for reviewing and benchmarking, Pavel! I agree with your suggestions. PFA patch with relevant changes. Thanks a lot. Best regards, Andrey Borodin. v11-0001-

Re: Yet another fast GiST build (typo)

I see this feature quite useful in concept and decided to test it. On a real database of 7 million rows I observed speedup of 4 times in case of single column index on points only and 2.5 times speedup in case of index on points with several included columns. Standard deviation between in series o

Re: Yet another fast GiST build (typo)

> 30 июля 2020 г., в 06:26, Thomas Munro написал(а): > > On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin > wrote: >> Thanks! Fixed. > > It's not a bug, but I think those 64 bit constants should be wrapped > in UINT64CONST(), following our convention. Thanks, fixed! > I'm confused about th

Re: Yet another fast GiST build (typo)

On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin wrote: > Thanks! Fixed. It's not a bug, but I think those 64 bit constants should be wrapped in UINT64CONST(), following our convention. I'm confused about these two patches: 0001 introduces gist_point_fastcmp(), but then 0002 changes it to gist_

Re: Yet another fast GiST build (typo)

> 10 июля 2020 г., в 10:53, Thomas Munro написал(а): > > On Tue, Jul 7, 2020 at 7:03 PM Andrey M. Borodin wrote: >> Oops. I've mismerged docs and did not notice this with check world. PFA v8 >> with fixed docs. > > It looks like point_zorder_internal() has the check for NaN in the wrong > p

Re: Yet another fast GiST build (typo)

On Tue, Jul 7, 2020 at 7:03 PM Andrey M. Borodin wrote: > Oops. I've mismerged docs and did not notice this with check world. PFA v8 > with fixed docs. It looks like point_zorder_internal() has the check for NaN in the wrong place.

Re: Yet another fast GiST build (typo)

> 6 июля 2020 г., в 17:55, Andrey M. Borodin написал(а): > > > >> 1 июля 2020 г., в 17:05, Daniel Gustafsson написал(а): >> >>> On 29 Feb 2020, at 18:24, Andrey M. Borodin wrote: >> >>> I've fixed this and added patch with GiST reloption to provide sort support >>> function. >> >> 0002

Re: Yet another fast GiST build (typo)

> 1 июля 2020 г., в 17:05, Daniel Gustafsson написал(а): > >> On 29 Feb 2020, at 18:24, Andrey M. Borodin wrote: > >> I've fixed this and added patch with GiST reloption to provide sort support >> function. > > 0002 in this patchset fails to apply, please submit a rebased version. I've > m

Re: Yet another fast GiST build (typo)

> On 29 Feb 2020, at 18:24, Andrey M. Borodin wrote: > I've fixed this and added patch with GiST reloption to provide sort support > function. 0002 in this patchset fails to apply, please submit a rebased version. I've marked the entry Waiting for Author in the meantime. cheers ./daniel

Re: Yet another fast GiST build (typo)

> On 29 февр. 2020 г., at 17:20, Erik Rijkers wrote: > > Small typo alert: > In v5-0002-Implement-GiST-build-using-sort-support.patch there is: > > + method is also optional and is used diring fast GiST build. > > 'diring' should be 'during' > Thanks! I've fixed this and added patch with

Re: Yet another fast GiST build (typo)

On 2020-02-29 13:13, Andrey M. Borodin wrote: Hi! On 24 февр. 2020 г., at 13:50, Andrey M. Borodin wrote: Hi Thomas! Thanks for looking into this! I’ll fix your notices asap. PFA v5. Thomas, I've used your wording almost exactly with explanation how point_zorder_internal() works. It has m