Re: _WINSOCK_DEPRECATED_NO_WARNINGS

2017-11-16 Thread Tom Lane
Glen Knowles writes: > On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane wrote: >> but evidently it chose the wrong cutoff for when to enable that >> symbol, because woodlouse is (or claims to be) running VS2013. > It's actually checking the wrong thing, the problem is the version of the > Windows SDK,

Re: _WINSOCK_DEPRECATED_NO_WARNINGS

2017-11-16 Thread Glen Knowles
On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane wrote: > * Also for VS2015, add a define that stops compiler complaints about > * using the old Winsock API. > */ > #if defined(_MSC_VER) && _MSC_VER >= 1900 > #define _WINSOCK_DEPRECATED_NO_WARNINGS > > but evident

_WINSOCK_DEPRECATED_NO_WARNINGS

2017-11-16 Thread Tom Lane
Checking the buildfarm to see if ed9b3606d broke anything, I notice that woodlouse is producing stacks of warnings like this: src/port/thread.c(134): warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable depr