Hi,
On 2018-11-18 12:46:14 -0500, Andrew Dunstan wrote:
> On 11/17/18 2:46 PM, Andres Freund wrote:
> > On 2018-07-12 11:28:46 -0400, Andrew Dunstan wrote:
> > > By inspection the perl header is just defining it to _isnan, for every MSC
> > > version.
> > Let's try undefining it before plperl.h th
On 11/17/18 2:46 PM, Andres Freund wrote:
Hi,
On 2018-07-12 11:28:46 -0400, Andrew Dunstan wrote:
On 07/12/2018 10:38 AM, Tom Lane wrote:
Andrew Dunstan writes:
On 07/12/2018 10:20 AM, Tom Lane wrote:
bowerbird and hamerkop have some gripes like this:
bowerbird | c:\perl64\lib\core\w
Hi,
On 2018-07-12 11:28:46 -0400, Andrew Dunstan wrote:
> On 07/12/2018 10:38 AM, Tom Lane wrote:
> > Andrew Dunstan writes:
> > > On 07/12/2018 10:20 AM, Tom Lane wrote:
> > > > bowerbird and hamerkop have some gripes like this:
> > > >
> > > > bowerbird | c:\perl64\lib\core\win32.h(218): w
On 07/12/2018 10:38 AM, Tom Lane wrote:
Andrew Dunstan writes:
On 07/12/2018 10:20 AM, Tom Lane wrote:
bowerbird and hamerkop have some gripes like this:
bowerbird | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro
redefinition (src/pl/plperl/SPI.c)
[G:\prog\bf\root\HE
Andrew Dunstan writes:
> On 07/12/2018 10:20 AM, Tom Lane wrote:
>> bowerbird and hamerkop have some gripes like this:
>>
>> bowerbird | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' :
>> macro redefinition (src/pl/plperl/SPI.c)
>> [G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
On 07/12/2018 10:20 AM, Tom Lane wrote:
Michael Paquier writes:
On Wed, Jul 11, 2018 at 09:13:40AM -0400, Alvaro Herrera wrote:
I just pushed it before seeing your message.
Fine as well, thanks for picking this up. The buildfarm shows no
failures about this patch.
I scraped all the compi
Michael Paquier writes:
> On Wed, Jul 11, 2018 at 09:13:40AM -0400, Alvaro Herrera wrote:
>> I just pushed it before seeing your message.
> Fine as well, thanks for picking this up. The buildfarm shows no
> failures about this patch.
I scraped all the compiler warnings from the buildfarm this m
On Wed, Jul 11, 2018 at 09:13:40AM -0400, Alvaro Herrera wrote:
> I just pushed it before seeing your message.
Fine as well, thanks for picking this up. The buildfarm shows no
failures about this patch.
--
Michael
signature.asc
Description: PGP signature
On 2018-Jul-11, Michael Paquier wrote:
> On Tue, Jul 10, 2018 at 04:23:42PM -0400, Tom Lane wrote:
> > Alvaro Herrera writes:
> >> On 2018-Jul-10, Tom Lane wrote:
> >>> I disagree --- including in c.h, as this would have us do,
> >>> seems like a huge expansion of the visibility of that header.
On Tue, Jul 10, 2018 at 04:23:42PM -0400, Tom Lane wrote:
> Alvaro Herrera writes:
>> On 2018-Jul-10, Tom Lane wrote:
>>> I disagree --- including in c.h, as this would have us do,
>>> seems like a huge expansion of the visibility of that header. Moreover,
>>> doing that only on Windows seems ce
Alvaro Herrera writes:
> On 2018-Jul-10, Tom Lane wrote:
>> I disagree --- including in c.h, as this would have us do,
>> seems like a huge expansion of the visibility of that header. Moreover,
>> doing that only on Windows seems certain to lead to missing-header
>> problems in the reverse direc
On 2018-Jul-10, Tom Lane wrote:
> Alvaro Herrera writes:
> > Oh, it looks like commits 33a7101281c6, 8e211f539146, 86dbbf20d849
> > (probably others) papered over this by the expedient of adding #include
> > to random .c files rather than your patch, which seems the
> > proper fix.
>
> I disag
Alvaro Herrera writes:
> On 2018-Jul-10, Emre Hasegeli wrote:
>> isnan() function is evidently not present on on Windows
>> before Visual Studio 2013. We define it on win32_port.h using
>> _isnan(). However _isnan() is also not present. It is on .
>> The patch is attached to include this from
On 2018-Jul-10, Emre Hasegeli wrote:
> isnan() function is evidently not present on on Windows
> before Visual Studio 2013. We define it on win32_port.h using
> _isnan(). However _isnan() is also not present. It is on .
> The patch is attached to include this from win32_port.h.
>
> Thanks to
isnan() function is evidently not present on on Windows
before Visual Studio 2013. We define it on win32_port.h using
_isnan(). However _isnan() is also not present. It is on .
The patch is attached to include this from win32_port.h.
Thanks to Thomas Munro for point this out to me [1]. It is
15 matches
Mail list logo
