Re: allow meson to find ICU in non-standard localtion

2023-03-08 Thread Jeff Davis
On Wed, 2023-03-08 at 17:30 +0100, Peter Eisentraut wrote: > So should we withdraw the patch from the commit fest? Withdrawn. If someone else is interested we can still pursue some improvements. Regards, Jeff Davis

Re: allow meson to find ICU in non-standard localtion

2023-03-08 Thread Peter Eisentraut
On 01.03.23 21:30, Jeff Davis wrote: On Wed, 2023-03-01 at 11:43 -0800, Jacob Champion wrote: I work around it by manually setting -Dextra_lib_dirs. I just tried doing that with ICU 72, and it worked without a patch. Hopefully that helps some? Yes, works, thank you. Obviously we'd like a

Re: allow meson to find ICU in non-standard localtion

2023-03-01 Thread Jeff Davis
On Wed, 2023-03-01 at 11:43 -0800, Jacob Champion wrote: > I work around it by manually setting -Dextra_lib_dirs. I just tried > doing that with ICU 72, and it worked without a patch. Hopefully that > helps some? Yes, works, thank you. Obviously we'd like a little better solution so that others

Re: allow meson to find ICU in non-standard localtion

2023-03-01 Thread Jacob Champion
On Sun, Feb 26, 2023 at 7:36 PM Jeff Davis wrote: > > On Sun, 2023-02-26 at 09:57 -0800, Andres Freund wrote: > > If you tell meson where to find the pkg-config file in those > > directories it'd > > also work. -Dpkg_config_path=... > > Setup is able to find it, which is good, but it seems like

Re: allow meson to find ICU in non-standard localtion

2023-02-26 Thread Jeff Davis
On Sun, 2023-02-26 at 09:57 -0800, Andres Freund wrote: > If you tell meson where to find the pkg-config file in those > directories it'd > also work. -Dpkg_config_path=... Setup is able to find it, which is good, but it seems like it's not adding it to RPATH so it's not working. I think we need

Re: allow meson to find ICU in non-standard localtion

2023-02-26 Thread Andres Freund
Hi, On 2023-02-22 10:26:23 -0800, Jeff Davis wrote: > I attached a simple patch that allows meson to find ICU in a non- > standard location if if you specify -Dextra_lib_dirs and > -Dextra_include_dirs. If you tell meson where to find the pkg-config file in those directories it'd also work.

Re: allow meson to find ICU in non-standard localtion

2023-02-24 Thread Nazir Bilal Yavuz
Hi, Thanks for the patch. On Wed, 22 Feb 2023 at 21:26, Jeff Davis wrote: > > I'm not sure it's the right thing to do though. One downside is that it > doesn't output the version that it finds, it only outputs "YES". - icu = dependency('icu-uc', required: icuopt.enabled()) - icu_i18n =

allow meson to find ICU in non-standard localtion

2023-02-22 Thread Jeff Davis
I attached a simple patch that allows meson to find ICU in a non- standard location if if you specify -Dextra_lib_dirs and -Dextra_include_dirs. I'm not sure it's the right thing to do though. One downside is that it doesn't output the version that it finds, it only outputs "YES". From