On Mon, Feb 13, 2023 at 07:50:53AM -0600, Justin Pryzby wrote:
> On Thu, May 13, 2021 at 12:01:22PM -0500, Justin Pryzby wrote:
> > postgres=# select amvalidate(123);
> > ERROR: cache lookup failed for operator class 123
> > The usual expectation is that sql callable functions should return null
On Thu, May 13, 2021 at 12:01:22PM -0500, Justin Pryzby wrote:
> postgres=# select amvalidate(123);
> ERROR: cache lookup failed for operator class 123
> The usual expectation is that sql callable functions should return null rather
> than hitting elog().
On Thu, May 13, 2021 at 2:22 PM Tom Lane
On Sat, May 15, 2021 at 12:00:37PM -0400, Robert Haas wrote:
> Oh, I didn't notice previously that Justin's proposal was to make the
> functions return NULL. He's correct that this is consistent with other
> cases, and if we go that way, then these queries need to be updated. I
> had just been imag
On Thu, May 13, 2021 at 4:49 PM Tom Lane wrote:
> The main reason I'm concerned about applying that rule to amvalidate
> is that then how do you know what's actually an error case?
>
> As a hardly-irrelevant counterexample, we have a whole bunch of
> regression tests that do something like
>
> SEL
Robert Haas writes:
> On Thu, May 13, 2021 at 2:22 PM Tom Lane wrote:
>> Meh. I'm not convinced that that position ought to apply to amvalidate.
> I am still of the opinion that we ought to apply it across the board,
> for consistency.
The main reason I'm concerned about applying that rule to
On Thu, May 13, 2021 at 2:22 PM Tom Lane wrote:
> Meh. I'm not convinced that that position ought to apply to amvalidate.
I am still of the opinion that we ought to apply it across the board,
for consistency. It makes it easier for humans to know which problems
are known to be reachable and whic
On Thu, May 13, 2021 at 02:22:16PM -0400, Tom Lane wrote:
> Justin Pryzby writes:
> > Per sqlsmith.
> > postgres=# select amvalidate(123);
> > ERROR: cache lookup failed for operator class 123
> > postgres=# \errverbose
> > ERROR: XX000: cache lookup failed for operator class 123
> > LOCATION:
Justin Pryzby writes:
> Per sqlsmith.
> postgres=# select amvalidate(123);
> ERROR: cache lookup failed for operator class 123
> postgres=# \errverbose
> ERROR: XX000: cache lookup failed for operator class 123
> LOCATION: amvalidate, amapi.c:125
> The usual expectation is that sql callable f
Per sqlsmith.
postgres=# select amvalidate(123);
ERROR: cache lookup failed for operator class 123
postgres=# \errverbose
ERROR: XX000: cache lookup failed for operator class 123
LOCATION: amvalidate, amapi.c:125
The usual expectation is that sql callable functions should return null rather
t
