Re: backend/nodes cleanup: Move loop variables definitions into for statement

2025-11-19 Thread Chao Li
On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut wrote: > > > In a couple of cases, you are changing the type of the loop variable > from Size to int. I would not expect such a change in a patch of this > nature. If you have a reason to change it, please explain it (but I > doubt the change is

Re: backend/nodes cleanup: Move loop variables definitions into for statement

2025-11-19 Thread Peter Eisentraut
On 12.11.25 09:00, Chao Li wrote: While working on the other patch [1] that touched tbm_add_tuples() under src/backend/nodes, I moved a loop variable into for statement by the way as I knew Peter Eisentraut had done some efforts about that, see [2]. However, Peter removed that change from the

Re: backend/nodes cleanup: Move loop variables definitions into for statement

2025-11-17 Thread Chao Li
Added to CF: https://commitfest.postgresql.org/patch/6227/ > On Nov 14, 2025, at 21:52, Chao Li wrote: > > > > On Wed, Nov 12, 2025 at 4:00 PM Chao Li wrote: > Hi Hackers, > > While working on the other patch [1] that touched tbm_add_tuples() under > src/backend/nodes, I moved a loop variab

Re: backend/nodes cleanup: Move loop variables definitions into for statement

2025-11-14 Thread Chao Li
On Wed, Nov 12, 2025 at 4:00 PM Chao Li wrote: > Hi Hackers, > > While working on the other patch [1] that touched tbm_add_tuples() under > src/backend/nodes, I moved a loop variable into for statement by the way as > I knew Peter Eisentraut had done some efforts about that, see [2]. > > However,

backend/nodes cleanup: Move loop variables definitions into for statement

2025-11-12 Thread Chao Li
Hi Hackers, While working on the other patch [1] that touched tbm_add_tuples() under src/backend/nodes, I moved a loop variable into for statement by the way as I knew Peter Eisentraut had done some efforts about that, see [2]. However, Peter removed that change from the patch and he said that sh