Hi,
On Mon, 2 Oct 2023 at 13:08, Heikki Linnakangas wrote:
>
> The first patch, to flush the bgwriter's WAL stats to the stats
> collector, seems like a straightforward bug fix, so committed and
> backpatched that. Thank you!
>
> I didn't look at the second patch.
Thanks for the push!
Actual co
The first patch, to flush the bgwriter's WAL stats to the stats
collector, seems like a straightforward bug fix, so committed and
backpatched that. Thank you!
I didn't look at the second patch.
--
Heikki Linnakangas
Neon (https://neon.tech)
Hi,
Created a commitfest entry for this.
Link: https://commitfest.postgresql.org/43/4405/
Regards,
Nazir Bilal Yavuz
Microsoft
On Thu, 22 Jun 2023 at 17:03, Melanie Plageman
wrote:
> On Wed, Jun 21, 2023 at 9:49 PM Kyotaro Horiguchi
> wrote:
> > Regarding the second patch, it introduces WAL I
On Wed, Jun 21, 2023 at 9:49 PM Kyotaro Horiguchi
wrote:
> Regarding the second patch, it introduces WAL IO time as a
> IOCONTEXT_NORMAL/IOOBJECT_WAL, but it doesn't seem to follow the
> convention or design of the pgstat_io component, which primarily
> focuses on shared buffer IOs.
I haven't rev
At Wed, 21 Jun 2023 18:52:26 +0300, Nazir Bilal Yavuz
wrote in
> I attached a WIP patch for showing WAL stats in pg_stat_io.
Yeah, your diagnosis appears accurate. I managed to trigger an
assertion failure quite easily when I added
"Assert(!pgstat_have_pending_wal()) just after the call to
pgst
Hi,
Thanks for the explanation.
On Wed, 21 Jun 2023 at 18:03, Matthias van de Meent <
boekewurm+postg...@gmail.com> wrote:
>
> On Wed, 21 Jun 2023 at 13:04, Nazir Bilal Yavuz
wrote:
> > I was trying to add WAL stats to pg_stat_io. While doing that I was
comparing pg_stat_wal and pg_stat_io's WAL
On Wed, 21 Jun 2023 at 13:04, Nazir Bilal Yavuz wrote:
>
> Hi,
>
> I was trying to add WAL stats to pg_stat_io. While doing that I was comparing
> pg_stat_wal and pg_stat_io's WAL stats and there was some inequality between
> the total number of WALs. I found that the difference comes from bgwri
Hi,
I was trying to add WAL stats to pg_stat_io. While doing that I was
comparing pg_stat_wal and pg_stat_io's WAL stats and there was some
inequality between the total number of WALs. I found that the difference
comes from bgwriter's WALs. bgwriter generates WAL but it doesn't flush
them because
