Re: bogus assert in logicalmsg_desc

2022-08-14 Thread Richard Guo
On Mon, Aug 15, 2022 at 12:17 AM Tomas Vondra wrote: > So prefix_size includes the null byte, so the assert points out at the > first payload byte. And of course, the check should be "==" because we > expect the byte to be \0, not the other way around. Yes, indeed. There is even a comment empha

Re: bogus assert in logicalmsg_desc

2022-08-14 Thread Masahiko Sawada
On Mon, Aug 15, 2022 at 1:17 AM Tomas Vondra wrote: > > Hi, > > while experimenting with logical messages, I ran into this assert in > logicalmsg_desc: > > Assert(prefix[xlrec->prefix_size] != '\0'); > > This seems to be incorrect, because LogLogicalMessage does this: > > xlrec.prefix_size

bogus assert in logicalmsg_desc

2022-08-14 Thread Tomas Vondra
Hi, while experimenting with logical messages, I ran into this assert in logicalmsg_desc: Assert(prefix[xlrec->prefix_size] != '\0'); This seems to be incorrect, because LogLogicalMessage does this: xlrec.prefix_size = strlen(prefix) + 1; So prefix_size includes the null byte, so the a