On Fri, Oct 20, 2023 at 2:31 AM Tom Lane wrote:
>
> Peter Smith writes:
> > PSA v2.
>
> Pushed.
>
Thanks for pushing.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Peter Smith writes:
> PSA v2.
Pushed.
regards, tom lane
On Thu, Oct 19, 2023 at 3:26 PM Vik Fearing wrote:
>
> On 10/19/23 06:17, Peter Smith wrote:
> >> In short, maybe the whole comment should just be
> >>
> >> /*
> >> * boolin - input function for type boolean
> >> */
> >>
> > How about "boolin - converts a boolean string value to 1 or 0"
On 10/19/23 06:17, Peter Smith wrote:
In short, maybe the whole comment should just be
/*
* boolin - input function for type boolean
*/
How about "boolin - converts a boolean string value to 1 or 0"
Personally, I do not like exposing the implementation of a boolean (it
is a base
On Thu, Oct 19, 2023 at 2:55 PM Tom Lane wrote:
>
> Richard Guo writes:
> > On Thu, Oct 19, 2023 at 10:35 AM Peter Smith wrote:
> >> I happened upon a function comment referring to non-existent code
> >> (that code was moved to another location many years ago).
> >>
> >> Probably better to move
Richard Guo writes:
> On Thu, Oct 19, 2023 at 10:35 AM Peter Smith wrote:
>> I happened upon a function comment referring to non-existent code
>> (that code was moved to another location many years ago).
>>
>> Probably better to move that comment too. Thoughts?
> Agreed. +1 to move that
On Thu, Oct 19, 2023 at 10:35 AM Peter Smith wrote:
> Hi.
>
> I happened upon a function comment referring to non-existent code
> (that code was moved to another location many years ago).
>
> Probably better to move that comment too. Thoughts?
Agreed. +1 to move that comment.
Thanks
Richard
Hi.
I happened upon a function comment referring to non-existent code
(that code was moved to another location many years ago).
Probably better to move that comment too. Thoughts?
PSA.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Relocate-old-comment.patch
Description: Binary
