On Thu, 2023-12-28 at 22:00 +0300, Alexander Lakhin wrote:
> But looking at the result with the comment above that "do" block, I
> wonder
> whether this successful CREATE COLLATION command is so important to
> perform
> it that tricky way, if we want to demonstrate that nondeterministic
> collation
28.12.2023 20:36, Jeff Davis wrote:
We do want that test to run though, right?
Yes, I think so.
I suspect that test line never worked reliably. The skip_test check at
the top guarantees that the collation named "en_US" exists, but that
doesn't mean that the OS understands the locale 'en_US'.
On Thu, 2023-12-28 at 18:00 +0300, Alexander Lakhin wrote:
> AFAICS, before that commit SELECT getdatabaseencoding() in the test
> returned SQL_ASCII, hence the test was essentially skipped, but now
> it
> returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US',
> ...)
> is reached.
We d
Hello Jeff,
22.12.2023 02:17, Jeff Davis wrote:
On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
Attached.
It appears to increase the coverage. I committed it and I'll see how
the buildfarm reacts.
Starting from the commit 8793c6005, I observe a failure of test
collate.windows.win1252 on
Hi
pá 22. 12. 2023 v 0:17 odesílatel Jeff Davis napsal:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
> > Attached.
>
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.
>
I tested it locally ( LANG=cs_CZ.UTF-8 ) without problems
Regards
Pav
On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
> Attached.
It appears to increase the coverage. I committed it and I'll see how
the buildfarm reacts.
Regards,
Jeff Davis
On Tue, 2023-12-12 at 18:56 -0800, Noah Misch wrote:
> > Yea. I wonder if the better fix would have been to copy
> > setenv("LC_MESSAGES", "C", 1);
> > to the initdb template creation. That afaict also fixes the issue,
> > with a
> > smaller blast radius?
>
> +1, that would restore the testing sem
Noah Misch writes:
> An alternative would be to declare that the tests are supported in one
> encoding+locale only, then stop testing others in the buildfarm.
Surely that's not even a thinkably acceptable choice.
regards, tom lane
On Tue, Oct 10, 2023 at 05:54:34PM -0700, Andres Freund wrote:
> On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> > After this, it seems "make check" no longer picks up the locale from
> > the system environment by default.
>
> Yea. I wonder if the better fix would have been to copy setenv("LC_ME
On Tue, 2023-10-10 at 17:54 -0700, Andres Freund wrote:
> Yea. I wonder if the better fix would have been to copy
> setenv("LC_MESSAGES", "C", 1);
> to the initdb template creation. That afaict also fixes the issue,
> with a
> smaller blast radius?
Sounds good to me. Is there anything else we shou
Hi,
On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> On Mon, 2023-09-11 at 19:23 -0700, Andres Freund wrote:
> > > So I think injecting --no-locale to the initdb line that creates
> > > the
> > > template is a better approach; something like the attached.
> >
> > Makes sense, thanks for taking c
On Mon, 2023-09-11 at 19:23 -0700, Andres Freund wrote:
> > So I think injecting --no-locale to the initdb line that creates
> > the
> > template is a better approach; something like the attached.
>
> Makes sense, thanks for taking care of this.
After this, it seems "make check" no longer picks u
Hi,
On 2023-08-29 17:54:24 +0200, Alvaro Herrera wrote:
> On 2023-Aug-27, Thomas Munro wrote:
>
> > On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule
> > wrote:
> > > So it looks so IPC::Run::run is ignore parent environment
> >
> > I guess the new initdb template captures lc_messages in
> > postg
út 29. 8. 2023 v 17:54 odesílatel Alvaro Herrera
napsal:
> On 2023-Aug-27, Thomas Munro wrote:
>
> > On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule
> wrote:
> > > So it looks so IPC::Run::run is ignore parent environment
> >
> > I guess the new initdb template captures lc_messages in
> > postgres
On 2023-Aug-27, Thomas Munro wrote:
> On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule wrote:
> > So it looks so IPC::Run::run is ignore parent environment
>
> I guess the new initdb template captures lc_messages in
> postgresql.conf, when it runs earlier? I guess if you put
> $node->append_conf('
Hi
so 26. 8. 2023 v 23:52 odesílatel Thomas Munro
napsal:
> On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule
> wrote:
> > So it looks so IPC::Run::run is ignore parent environment
>
> I guess the new initdb template captures lc_messages in
> postgresql.conf, when it runs earlier? I guess if you p
On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule wrote:
> So it looks so IPC::Run::run is ignore parent environment
I guess the new initdb template captures lc_messages in
postgresql.conf, when it runs earlier? I guess if you put
$node->append_conf('postgresql.conf', 'lc_messages=C'); into
src/bin/
Hi
pá 25. 8. 2023 v 9:12 odesílatel Pavel Stehule
napsal:
>
>
> pá 25. 8. 2023 v 8:22 odesílatel Matthias van de Meent <
> boekewurm+postg...@gmail.com> napsal:
>
>>
>>
>> On Fri, 25 Aug 2023, 05:54 Pavel Stehule,
>> wrote:
>>
>>> Hi
>>>
>>> today build is broken on my Fedora 39
>>>
>>> Regards
pá 25. 8. 2023 v 8:22 odesílatel Matthias van de Meent <
boekewurm+postg...@gmail.com> napsal:
>
>
> On Fri, 25 Aug 2023, 05:54 Pavel Stehule, wrote:
>
>> Hi
>>
>> today build is broken on my Fedora 39
>>
>> Regards
>>
>> Pavel
>>
>> make[2]: Opouští se adresář
>> „/home/pavel/src/postgresql.mast
On Fri, 25 Aug 2023, 05:54 Pavel Stehule, wrote:
> Hi
>
> today build is broken on my Fedora 39
>
> Regards
>
> Pavel
>
> make[2]: Opouští se adresář
> „/home/pavel/src/postgresql.master/src/bin/initdb“
> make -C pg_amcheck check
> make[2]: Vstupuje se do adresáře
> „/home/pavel/src/postgresql.ma
pá 25. 8. 2023 v 8:10 odesílatel Pavel Stehule
napsal:
> Hi
>
> pá 25. 8. 2023 v 7:38 odesílatel Thomas Munro
> napsal:
>
>> On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule
>> wrote:
>> > today build is broken on my Fedora 39
>>
>> Has commit 252dcb32 somehow upset some kind of bleeding edge btrf
Hi
pá 25. 8. 2023 v 7:38 odesílatel Thomas Munro
napsal:
> On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule
> wrote:
> > today build is broken on my Fedora 39
>
> Has commit 252dcb32 somehow upset some kind of bleeding edge btrfs
> filesystem? That's a wild guess and I can't really imagine how bu
On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule wrote:
> today build is broken on my Fedora 39
Has commit 252dcb32 somehow upset some kind of bleeding edge btrfs
filesystem? That's a wild guess and I can't really imagine how but
apparently your database files are totally messed up...
Hi
today build is broken on my Fedora 39
Regards
Pavel
make[2]: Opouští se adresář
„/home/pavel/src/postgresql.master/src/bin/initdb“
make -C pg_amcheck check
make[2]: Vstupuje se do adresáře
„/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
echo "# +++ tap check in src/bin/pg_amcheck +++"
24 matches
Mail list logo
