Re: buffer refcount leak in foreign batch insert code

2023-05-02 Thread Alexander Pyhalov
Michael Paquier писал 2023-04-25 04:30: On Mon, Apr 24, 2023 at 09:57:10AM +0900, Michael Paquier wrote: The attached is what I am finishing with, with a minimal regression test added to postgres_fdw. Two partitions are enough. Well, I have gone through that again this morning, and applied th

Re: buffer refcount leak in foreign batch insert code

2023-04-24 Thread Michael Paquier
On Mon, Apr 24, 2023 at 09:57:10AM +0900, Michael Paquier wrote: > The attached is what I am finishing with, with a minimal regression > test added to postgres_fdw. Two partitions are enough. Well, I have gone through that again this morning, and applied the fix down to 14. The buildfarm is dige

Re: buffer refcount leak in foreign batch insert code

2023-04-23 Thread Michael Paquier
On Fri, Apr 21, 2023 at 07:16:03PM +0900, Michael Paquier wrote: > On Fri, Apr 21, 2023 at 01:07:03PM +0300, Alexander Pyhalov wrote: >> We've found that in cases like the one attached, when we insert into foreign >> partition with batch_size set, buffer refcount leak is detected. >> >> The above

Re: buffer refcount leak in foreign batch insert code

2023-04-21 Thread Michael Paquier
On Fri, Apr 21, 2023 at 01:07:03PM +0300, Alexander Pyhalov wrote: > We've found that in cases like the one attached, when we insert into foreign > partition with batch_size set, buffer refcount leak is detected. > > The above example we see a dozen of similar messages: > > repro_small.sql:31: WA

buffer refcount leak in foreign batch insert code

2023-04-21 Thread Alexander Pyhalov
Hi. We've found that in cases like the one attached, when we insert into foreign partition with batch_size set, buffer refcount leak is detected. The above example we see a dozen of similar messages: repro_small.sql:31: WARNING: buffer refcount leak: [14621] (rel=base/16718/16732, blockNum=