Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-20 Thread Andres Freund
Hi, On 2023-06-21 08:54:48 +0530, Amit Kapila wrote: > On Mon, Jun 19, 2023 at 11:47 PM Andres Freund wrote: > > > > On June 19, 2023 10:37:45 AM PDT, Tom Lane wrote: > > >Andres Freund writes: > > >> Unfortunately, due to some personal life business, it took until for me > > >> to > > >>

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-20 Thread Amit Kapila
On Mon, Jun 19, 2023 at 11:47 PM Andres Freund wrote: > > On June 19, 2023 10:37:45 AM PDT, Tom Lane wrote: > >Andres Freund writes: > >> Unfortunately, due to some personal life business, it took until for me to > >> feel comfortable pushing the fix for > >>

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-19 Thread Andres Freund
Hi, On June 19, 2023 10:37:45 AM PDT, Tom Lane wrote: >Andres Freund writes: >> Unfortunately, due to some personal life business, it took until for me to >> feel comfortable pushing the fix for >> https://www.postgresql.org/message-id/zezdj1h61ryrm...@msg.df7cb.de >> (FileFallocate() erroring

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-19 Thread Tom Lane
Andres Freund writes: > Unfortunately, due to some personal life business, it took until for me to > feel comfortable pushing the fix for > https://www.postgresql.org/message-id/zezdj1h61ryrm...@msg.df7cb.de > (FileFallocate() erroring out with EINTR due to running on tmpfs). > Do you want me to

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-19 Thread Andres Freund
Hi Tom, Unfortunately, due to some personal life business, it took until for me to feel comfortable pushing the fix for https://www.postgresql.org/message-id/zezdj1h61ryrm...@msg.df7cb.de (FileFallocate() erroring out with EINTR due to running on tmpfs). Do you want me to hold off before beta2

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-09 Thread Andres Freund
Hi, On 2023-06-06 21:53:00 +0200, Alvaro Herrera wrote: > On 2023-Apr-24, Andres Freund wrote: > > > A prototype of that approach is attached. I pushed the retry handling into > > the > > pg_* routines where applicable. I guess we could add pg_* routines for > > FileFallocate(), FilePrewarm()

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-07 Thread Christoph Berg
Re: Alvaro Herrera > > Christoph, could you verify this fixes your issue? > > So, is anyone making progress on this? I don't see anything in the > thread. Well, I had reported that I haven't been seeing any problems since I applied the patch to the postgresql-16.deb package. So for me, the

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-06-06 Thread Alvaro Herrera
On 2023-Apr-24, Andres Freund wrote: > A prototype of that approach is attached. I pushed the retry handling into the > pg_* routines where applicable. I guess we could add pg_* routines for > FileFallocate(), FilePrewarm() etc as well, but I didn't do that here. > > Christoph, could you verify

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-05-23 Thread Kyotaro Horiguchi
At Tue, 23 May 2023 19:28:45 -0700, Andres Freund wrote in > Hi, > > On 2023-05-24 10:56:28 +0900, Kyotaro Horiguchi wrote: > > At Wed, 26 Apr 2023 11:37:55 +1200, Thomas Munro > > wrote in > > > On Tue, Apr 25, 2023 at 12:16 PM Andres Freund wrote: > > > > On 2023-04-24 15:32:25 -0700,

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-05-23 Thread Andres Freund
Hi, On 2023-05-24 10:56:28 +0900, Kyotaro Horiguchi wrote: > At Wed, 26 Apr 2023 11:37:55 +1200, Thomas Munro > wrote in > > On Tue, Apr 25, 2023 at 12:16 PM Andres Freund wrote: > > > On 2023-04-24 15:32:25 -0700, Andres Freund wrote: > > > > We obviously can add a retry loop to

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-05-23 Thread Kyotaro Horiguchi
At Wed, 26 Apr 2023 11:37:55 +1200, Thomas Munro wrote in > On Tue, Apr 25, 2023 at 12:16 PM Andres Freund wrote: > > On 2023-04-24 15:32:25 -0700, Andres Freund wrote: > > > We obviously can add a retry loop to FileFallocate(), similar to what's > > > already present e.g. in FileRead(). But I

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-05-23 Thread Michael Paquier
On Tue, May 23, 2023 at 04:25:59PM +0200, Christoph Berg wrote: > I believe this issue is still open for PG16. Right. I've added an item to the list, to not forget. -- Michael signature.asc Description: PGP signature

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-05-23 Thread Christoph Berg
Re: Andres Freund > A prototype of that approach is attached. I pushed the retry handling into the > pg_* routines where applicable. I guess we could add pg_* routines for > FileFallocate(), FilePrewarm() etc as well, but I didn't do that here. > > Christoph, could you verify this fixes your

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-25 Thread Thomas Munro
On Tue, Apr 25, 2023 at 12:16 PM Andres Freund wrote: > On 2023-04-24 15:32:25 -0700, Andres Freund wrote: > > We obviously can add a retry loop to FileFallocate(), similar to what's > > already present e.g. in FileRead(). But I wonder if we shouldn't go a bit > > further, and do it for all the

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-25 Thread Christoph Berg
Re: Andres Freund > A prototype of that approach is attached. I pushed the retry handling into the > pg_* routines where applicable. I guess we could add pg_* routines for > FileFallocate(), FilePrewarm() etc as well, but I didn't do that here. > > Christoph, could you verify this fixes your

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-24 Thread Andres Freund
Hi, On 2023-04-24 15:32:25 -0700, Andres Freund wrote: > On 2023-04-24 10:53:35 +0200, Christoph Berg wrote: > > I'm often seeing PG16 builds erroring out in the pgbench tests: > > I don't think the disk is full since it's always hitting that same > > spot, on some of the builds: > > Yea, the

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-24 Thread Andres Freund
Hi, On 2023-04-24 10:53:35 +0200, Christoph Berg wrote: > I'm often seeing PG16 builds erroring out in the pgbench tests: Interesting! > I don't think the disk is full since it's always hitting that same > spot, on some of the builds: Yea, the EINTR pretty clearly indicates that it's not

Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-24 Thread Melanie Plageman
' > 00:33:14 # doesn't match '(?^:processed: 125/125)' > 00:33:14 # Failed test 'concurrent OID generation stderr /(?^:^$)/' > 00:33:14 # at t/001_pgbench_with_server.pl line 31. > 00:33:14 # 'pgbench: error: client 2 script 0 aborted in > command 0 query 0:

could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

2023-04-24 Thread Christoph Berg
14 # ' 00:33:14 # doesn't match '(?^:processed: 125/125)' 00:33:14 # Failed test 'concurrent OID generation stderr /(?^:^$)/' 00:33:14 # at t/001_pgbench_with_server.pl line 31. 00:33:14 # 'pgbench: error: client 2 script 0 aborted in command 0 query 0: ERROR: could