Christoph Berg writes:
> Should the removal of "register" be backported to support that better?
Perhaps. It's early days yet, but nobody has complained that that
broke anything in v16, so I'm guessing it'd be fine.
regards, tom lane
Re: Tom Lane
> > I hit this again while porting cplupluscheck to be invoked by meson as
> > well. ISTM that we should just remove the uses of register.
>
> OK by me.
>
> > I tried to use -Wregister to keep us honest going forward, but unfortunately
> > it only works with a C++ compiler...
>
> I
Hi,
On 2022-09-24 16:01:25 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I hit this again while porting cplupluscheck to be invoked by meson as
> > well. ISTM that we should just remove the uses of register.
>
> OK by me.
Done. Thanks Tom, Peter.
Andres Freund writes:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register.
OK by me.
> I tried to use -Wregister to keep us honest going forward, but unfortunately
> it only works with a C++ compiler...
I think
On Sat, Sep 24, 2022 at 12:11 PM Andres Freund wrote:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register. Yes, some very old
> compilers might generate worse code without register, but I don't think we
> need to
Hi,
On 2022-03-08 10:59:02 -0800, Andres Freund wrote:
> On 2022-03-08 13:46:36 -0500, Tom Lane wrote:
> > Andres Freund writes:
> > > When running cpluspluscheck I get many many complaints like
> > > /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning:
> > > ISO C++17 does
It seems we should just remove the use of register?
I have a vague idea that it was once important to say "register" if
you are going to use the variable in an asm snippet that requires it
to be in a register. That might be wrong, or it might be obsolete
even if once true. We could try
Hi,
On 2022-03-08 13:46:36 -0500, Tom Lane wrote:
> Andres Freund writes:
> > When running cpluspluscheck I get many many complaints like
> > /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning: ISO
> > C++17 does not allow ‘register’ storage class specifier [-Wregister]
>
>
Andres Freund writes:
> When running cpluspluscheck I get many many complaints like
> /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning: ISO
> C++17 does not allow ‘register’ storage class specifier [-Wregister]
Interesting, I don't see that here.
> It seems we should just
Hi,
When running cpluspluscheck I get many many complaints like
In file included from /tmp/pg-test-repo/src/include/port/atomics.h:70,
from /tmp/pg-test-repo/src/include/utils/dsa.h:17,
from /tmp/pg-test-repo/src/include/nodes/tidbitmap.h:26,
10 matches
Mail list logo
