Re: cpluspluscheck vs ICU

2023-08-08 Thread Peter Eisentraut
On 08.08.23 01:35, Andres Freund wrote: Hi, On 2023-03-10 20:10:30 -0800, Andres Freund wrote: On 2023-03-10 19:37:27 -0800, Andres Freund wrote: I just hit this once more - and I figured out a fairly easy fix: We just need a #ifndef U_DEFAULT_SHOW_DRAFT #define U_DEFAULT_SHOW_DRAFT 0

Re: cpluspluscheck vs ICU

2023-08-07 Thread Andres Freund
Hi, On 2023-03-10 20:10:30 -0800, Andres Freund wrote: > On 2023-03-10 19:37:27 -0800, Andres Freund wrote: > > I just hit this once more - and I figured out a fairly easy fix: > > > > We just need a > > #ifndef U_DEFAULT_SHOW_DRAFT > > #define U_DEFAULT_SHOW_DRAFT 0 > > #endif > > before

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2023-03-10 19:37:27 -0800, Andres Freund wrote: > On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > > On 3/22/22 22:23, Andres Freund wrote: > > > That only helps when running the CI/cfbot setup. Fixing it for other > > > (manual

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > On 3/22/22 22:23, Andres Freund wrote: > > That only helps when running the CI/cfbot setup. Fixing it for other > > (manual or buildfarm) users would be nice. Luckily crake isn't

Re: cpluspluscheck vs ICU

2022-03-23 Thread Andres Freund
Hi, On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > On 3/22/22 22:23, Andres Freund wrote: > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > >> I was about to propose adding headerscheck / cpluspluscheck to the CI file > >> so > >> that cfbot can catch future issues. > > The

Re: cpluspluscheck vs ICU

2022-03-23 Thread Andrew Dunstan
On 3/22/22 22:23, Andres Freund wrote: > Hi, > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: >> I was about to propose adding headerscheck / cpluspluscheck to the CI file so >> that cfbot can catch future issues. > The attached patch does so, with ICU disabled to avoid the problems

Re: cpluspluscheck vs ICU

2022-03-22 Thread Thomas Munro
On Wed, Mar 23, 2022 at 3:23 PM Andres Freund wrote: > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > > I was about to propose adding headerscheck / cpluspluscheck to the CI file > > so > > that cfbot can catch future issues. > > The attached patch does so, with ICU disabled to avoid the

Re: cpluspluscheck vs ICU

2022-03-22 Thread Andres Freund
Hi, On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > I was about to propose adding headerscheck / cpluspluscheck to the CI file so > that cfbot can catch future issues. The attached patch does so, with ICU disabled to avoid the problems discussed in the thread. Example run:

cpluspluscheck vs ICU

2022-03-22 Thread Andres Freund
Hi, I was about to propose adding headerscheck / cpluspluscheck to the CI file so that cfbot can catch future issues. Unfortunately running cpluspluscheck with ICU enabled is, um, not fun: There's 30k lines of error output. /home/andres/src/postgresql/src/tools/pginclude/cpluspluscheck