Re: dead code in pg_upgrade

2025-03-17 Thread Nathan Bossart
On Mon, Mar 17, 2025 at 01:56:49PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> I noticed that the condition it's referring to >> if (strlen(old_cluster.tablespace_suffix) == 0) >> doesn't appear to have been reachable since support for upgrading from >> pre-9.2 was removed in v

Re: dead code in pg_upgrade

2025-03-17 Thread Tom Lane
Nathan Bossart writes: > I noticed that the condition it's referring to > if (strlen(old_cluster.tablespace_suffix) == 0) > doesn't appear to have been reachable since support for upgrading from > pre-9.2 was removed in v15 (commit e469f0a). Before then, this case seems > to have on

dead code in pg_upgrade

2025-03-17 Thread Nathan Bossart
While trying to decipher this comment: /* * Do the old cluster's per-database directories share a directory * with a new version-specific tablespace? */ I noticed that the condition it's referring to if (strlen(o