Re: display of variables in EXPLAIN VERBOSE

2019-04-22 Thread Amit Langote
On 2019/04/23 0:58, Tom Lane wrote: > BTW, now that I look at this, I think the reason why I didn't make > tlist printouts pay attention to VERBOSE for this purpose is that > you don't get them at all if not verbose: > > regression=# explain select * from tt; > QUERY PLAN

Re: display of variables in EXPLAIN VERBOSE

2019-04-22 Thread Tom Lane
David Rowley writes: > I'd vote to make the code match the documentation, but probably > implement it by adding a new field to ExplainState and just calculate > what to do once in ExplainQuery() instead of calculating what to do in > various random places. Yeah, this is none too consistent: $ gr

Re: display of variables in EXPLAIN VERBOSE

2019-04-22 Thread David Rowley
On Mon, 22 Apr 2019 at 19:49, Amit Langote wrote: > Seeing that "Sort Key" is always displayed with the range table alias, I > checked explain.c to see why the discrepancy exists and it seems that > show_plan_tlist() (and show_tablesample()) use the following condition for > whether or not to use

display of variables in EXPLAIN VERBOSE

2019-04-22 Thread Amit Langote
Hi, ISTM show_plan_tlist()'s rule of whether to the show range table prefix with displayed variables contradicts the description of the VERBOSE option in EXPLAIN documentation, which is as follows: === VERBOSE Display additional information regarding the plan. Specifically, include the outpu