On Thu, Jun 2, 2022 at 6:14 PM Etsuro Fujita wrote:
> On Thu, Jun 2, 2022 at 10:23 AM Amit Langote wrote:
> > On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita
> > wrote:
> > > On Tue, May 31, 2022 at 9:35 PM Robert Haas wrote:
> > > > I would probably just update the synopsis. It's not very hard t
On Thu, Jun 2, 2022 at 10:23 AM Amit Langote wrote:
> On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita wrote:
> > On Tue, May 31, 2022 at 9:35 PM Robert Haas wrote:
> > > I would probably just update the synopsis. It's not very hard to
> > > figure out what's likely to happen even without clicking t
On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita wrote:
> On Tue, May 31, 2022 at 9:35 PM Robert Haas wrote:
> > I would probably just update the synopsis. It's not very hard to
> > figure out what's likely to happen even without clicking through the
> > link, so it seems like it's just being long-wi
On Tue, May 31, 2022 at 9:35 PM Robert Haas wrote:
> On Mon, May 30, 2022 at 2:27 AM Etsuro Fujita wrote:
> > On Fri, May 27, 2022 at 9:22 PM Amit Langote
> > wrote:
> > > On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita
> > > wrote:
> > > > Attached is a patch for that.
> >
> > > I think we sh
On Mon, May 30, 2022 at 2:27 AM Etsuro Fujita wrote:
> On Fri, May 27, 2022 at 9:22 PM Amit Langote wrote:
> > On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita
> > wrote:
> > > Attached is a patch for that.
>
> > I think we should also rewrite the description to match the CREATE
> > TABLE's text,
Amit-san,
On Fri, May 27, 2022 at 9:22 PM Amit Langote wrote:
> On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita wrote:
> > Attached is a patch for that.
> I think we should also rewrite the description to match the CREATE
> TABLE's text, as in the attached updated patch.
Actually, I thought the
On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita wrote:
> On Fri, May 27, 2022 at 1:58 AM Robert Haas wrote:
> > Committed, except I adjusted the v11 version so that the CREATE
> > FOREIGN TABLE documentation would match the CREATE TABLE documentation
> > in that branch.
>
> I think we should fix th
On Fri, May 27, 2022 at 1:58 AM Robert Haas wrote:
> Committed, except I adjusted the v11 version so that the CREATE
> FOREIGN TABLE documentation would match the CREATE TABLE documentation
> in that branch.
I think we should fix the syntax synopsis in the Parameters section
of the CREATE FOREIGN
On Fri, May 27, 2022 at 1:58 AM Robert Haas wrote:
> On Thu, May 26, 2022 at 1:50 AM Amit Langote wrote:
> > Attached 2 patches -- one for PG 11 onwards and another for PG 10.
>
> Committed, except I adjusted the v11 version so that the CREATE
> FOREIGN TABLE documentation would match the CREATE
On Thu, May 26, 2022 at 1:50 AM Amit Langote wrote:
> Attached 2 patches -- one for PG 11 onwards and another for PG 10.
Committed, except I adjusted the v11 version so that the CREATE
FOREIGN TABLE documentation would match the CREATE TABLE documentation
in that branch.
--
Robert Haas
EDB: htt
On Wed, May 25, 2022 at 9:44 PM Robert Haas wrote:
> On Sat, May 21, 2022 at 9:09 AM Justin Pryzby wrote:
> > It looks like the docs weren't updated in 6f6b99d13 for v11.
>
> In my defense, that commit definitely contained documentation changes.
> It updated alter_table.sgml and create_table.sgml
On Sat, May 21, 2022 at 9:09 AM Justin Pryzby wrote:
> It looks like the docs weren't updated in 6f6b99d13 for v11.
In my defense, that commit definitely contained documentation changes.
It updated alter_table.sgml and create_table.sgml. I guess we missed
create_foreign_table.sgml, though.
> The
It looks like the docs weren't updated in 6f6b99d13 for v11.
The docs also seem to omit "FOR VALUES" literal.
And don't define partition_bound_spec (which I didn't fix here).
diff --git a/doc/src/sgml/ref/create_foreign_table.sgml
b/doc/src/sgml/ref/create_foreign_table.sgml
index b374d8645db..1
13 matches
Mail list logo
