Re: doc: alter table references bogus table-specific planner parameters

2020-01-23 Thread Michael Paquier
On Wed, Jan 22, 2020 at 01:53:32PM +0900, Michael Paquier wrote: >> @@ -714,9 +714,7 @@ WITH ( MODULUS > class="parameter">numeric_literal, REM >> >>SHARE UPDATE EXCLUSIVE lock will be taken for >>fillfactor, toast and autovacuum storage parameters, as well as the >> -

Re: doc: alter table references bogus table-specific planner parameters

2020-01-21 Thread Michael Paquier
On Tue, Jan 21, 2020 at 07:27:47PM -0600, Justin Pryzby wrote: > Attached minimal patch with just this hunk. > > https://commitfest.postgresql.org/27/2417/ > => RFC I think that you should be more careful when you think that you create a new thread. On my client for example, I can see that this

Re: doc: alter table references bogus table-specific planner parameters

2020-01-21 Thread Justin Pryzby
esql.org/27/2417/ => RFC Justin (I'm resending in a new thread since it looks like the first message was somehow sent as a reply to an unrelated thread.) >From 23873bbf32740b0f78f2102eb615e6a6aa615b8c Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sun, 5 Jan 2020 19:39:29 -0600 Subjec

Re: doc: alter table references bogus table-specific planner parameters

2020-01-05 Thread Simon Riggs
On Mon, 6 Jan 2020 at 04:13, Justin Pryzby wrote: > > > I agree with the sentiment of the third doc change, but your patch > removes > > the mention of n_distinct, which isn't appropriate. > > I think it's correct to remove n_distinct there, as it's documented > previously, > since e5550d5f.

Re: doc: alter table references bogus table-specific planner parameters

2020-01-05 Thread Justin Pryzby
On Mon, Jan 06, 2020 at 03:48:52AM +, Simon Riggs wrote: > On Mon, 6 Jan 2020 at 02:56, Justin Pryzby wrote: > > > commit 6f3a13ff058f15d565a30c16c0c2cb14cc994e42 Enhance docs for ALTER > > TABLE lock levels of storage parms > > Author: Simon Riggs > > Date: Mon Mar 6 16:48:12 2017 +0530

Re: doc: alter table references bogus table-specific planner parameters

2020-01-05 Thread Simon Riggs
On Mon, 6 Jan 2020 at 02:56, Justin Pryzby wrote: > commit 6f3a13ff058f15d565a30c16c0c2cb14cc994e42 Enhance docs for ALTER > TABLE lock levels of storage parms > Author: Simon Riggs > Date: Mon Mar 6 16:48:12 2017 +0530 > > > SET ( class="PARAMETER">storage_parameter =

doc: alter table references bogus table-specific planner parameters

2020-01-05 Thread Justin Pryzby
commit 6f3a13ff058f15d565a30c16c0c2cb14cc994e42 Enhance docs for ALTER TABLE lock levels of storage parms Author: Simon Riggs Date: Mon Mar 6 16:48:12 2017 +0530 SET ( storage_parameter = value [, ... ] ) ... - Changing fillfactor and autovacuum storage parameters acquires a