Re: doc fixes: vacuum_cleanup_index_scale_factor

thanks to everyone, pushed -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/

Re: doc fixes: vacuum_cleanup_index_scale_factor

On 05/08/2018 02:05 PM, Justin Pryzby wrote: 3rd iteration ; thanks for bearing with me. On Tue, May 08, 2018 at 12:35:00PM +0300, Alexander Korotkov wrote: Hi, Justin! Thank you for revising documentation patch. On Mon, May 7, 2018 at 7:55 PM, Justin Pryzby wrote: +

Re: doc fixes: vacuum_cleanup_index_scale_factor

3rd iteration ; thanks for bearing with me. On Tue, May 08, 2018 at 12:35:00PM +0300, Alexander Korotkov wrote: > Hi, Justin! > > Thank you for revising documentation patch. > > On Mon, May 7, 2018 at 7:55 PM, Justin Pryzby wrote: +In order to detect stale index

Re: doc fixes: vacuum_cleanup_index_scale_factor

Hi, Justin! Thank you for revising documentation patch. On Mon, May 7, 2018 at 7:55 PM, Justin Pryzby wrote: > On Mon, May 07, 2018 at 07:26:25PM +0300, Alexander Korotkov wrote: > > Hi! > > > > I've revised docs and comments, and also made some fixes in the code. > > See

Re: doc fixes: vacuum_cleanup_index_scale_factor

On Mon, May 07, 2018 at 07:26:25PM +0300, Alexander Korotkov wrote: > Hi! > > I've revised docs and comments, and also made some fixes in the code. > See the attached patchset. > > * 0004-btree-cleanup-docs-comments-fixes.patch > Documentation and comment improvements from Justin Pryzby >

Re: doc fixes: vacuum_cleanup_index_scale_factor

Hi! I've revised docs and comments, and also made some fixes in the code. See the attached patchset. * 0001-vacuum-cleanup-index-scale-factor-user-set.patch Changes vacuum_cleanup_index_scale_factor GUC to PGC_USERSET, because it might be useful to change in specific session. *

Re: doc fixes: vacuum_cleanup_index_scale_factor

Hi! Thank you for your attention on this subject. It's definitely right, that documentation needs to be revised in these places. On Wed, May 2, 2018 at 6:43 PM, Justin Pryzby wrote: > index eabe2a9..e305de9 100644 > --- a/doc/src/sgml/config.sgml > +++

Re: doc fixes: vacuum_cleanup_index_scale_factor

On Wed, May 2, 2018 at 11:43 AM, Justin Pryzby wrote: > 2nd attempt That looks like good English to me. I can't vouch for whether it's technically correct. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: doc fixes: vacuum_cleanup_index_scale_factor

On Tue, May 1, 2018 at 10:30 PM, Justin Pryzby wrote: > -When no tuples were deleted from the heap, B-tree indexes might still > -be scanned during VACUUM cleanup stage by two > -reasons. The first reason is that B-tree index contains deleted >

doc fixes: vacuum_cleanup_index_scale_factor

Introduced 857f9c36cda520030381bd8c2af20adf0ce0e1d4 The "minimal version" should probably be "minimum version", but I didn't include it here. Also, the documentation doesn't indicate the default value of -1 (or its special meaning). Also, my understanding of this feature changed when I read