Re: docs about FKs referencing partitioned tables

2019-05-29 Thread Michael Paquier
On Wed, May 29, 2019 at 02:33:26PM +0900, Amit Langote wrote: > But couple of other points mentioned in 5.11.3.3. Caveats (of 5.11. Table > Partitioning) are already repeated in 5.10.1. Caveats; for example, note > the point about VACUUM, ANALYZE, INSERT ON CONFLICT, etc. applying to > single

Re: docs about FKs referencing partitioned tables

2019-05-28 Thread Amit Langote
Hi, On 2019/05/29 14:01, Paul A Jungwirth wrote: > On Sun, May 26, 2019 at 7:49 PM Michael Paquier wrote: >> ... However you are adding a paragraph for something which is >> completely unrelated to the issue we are trying to fix. If I were to >> add something, I think that I would be more

Re: docs about FKs referencing partitioned tables

2019-05-28 Thread Paul A Jungwirth
On Sun, May 26, 2019 at 7:49 PM Michael Paquier wrote: > Well, the point I would like to outline is that section 5.11.2 about > declarative partitioning and 5.11.3 about partitioning with > inheritance treat about two separate, independent partitioning > methods. So removing the paragraph from

Re: docs about FKs referencing partitioned tables

2019-05-26 Thread Michael Paquier
On Thu, May 23, 2019 at 12:02:56AM -0700, Paul A Jungwirth wrote: > The section in the docs (5.10) just before the one I changed has > similar warnings: > >> Other types of constraints (unique, primary key, and foreign key >> constraints) are not inherited. > > and > >> A serious limitation of

Re: docs about FKs referencing partitioned tables

2019-05-23 Thread Paul A Jungwirth
On Wed, May 22, 2019 at 8:06 PM Michael Paquier wrote: > Looking closer, you are adding that: > + > + > + While primary keys are supported on tables using inheritance > + for partitioning, foreign keys referencing these tables are not > + supported. (Foreign key

Re: docs about FKs referencing partitioned tables

2019-05-22 Thread Michael Paquier
On Mon, May 20, 2019 at 10:35:31PM -0700, Paul A Jungwirth wrote: > I agree that sounds better. To avoid repeating it I changed the second > instance to just "inherited tables". New patch attached. Looking closer, you are adding that: + + + While primary keys are supported on

Re: docs about FKs referencing partitioned tables

2019-05-20 Thread Paul A Jungwirth
On Mon, May 20, 2019 at 10:18 PM Michael Paquier wrote: > Could you define what is an "inheritance-partitioned" table? I know > of partitioned tables, inherited tables and tables which make use > of inheritance for partitioning (hence Inheritance Partitioning), but > the paragraph you are adding

Re: docs about FKs referencing partitioned tables

2019-05-20 Thread Michael Paquier
On Mon, May 20, 2019 at 09:42:52PM -0700, Paul A Jungwirth wrote: > I noticed the docs at > https://www.postgresql.org/docs/devel/ddl-partitioning.html still say > you can't create a foreign key referencing a partitioned table, even > though the docs for >

Re: docs about FKs referencing partitioned tables

2019-05-20 Thread Paul A Jungwirth
On Mon, May 20, 2019 at 9:59 PM Amit Langote wrote: > Would you like me to edit the wiki to add this to open items? That would be helpful for sure. Thanks! Paul

Re: docs about FKs referencing partitioned tables

2019-05-20 Thread Amit Langote
On 2019/05/21 14:05, Paul A Jungwirth wrote: > On Mon, May 20, 2019 at 9:59 PM Amit Langote > wrote: >> Would you like me to edit the wiki to add this to open items? > > That would be helpful for sure. Thanks! OK, done. Thanks, Amit

Re: docs about FKs referencing partitioned tables

2019-05-20 Thread Amit Langote
On 2019/05/21 13:42, Paul A Jungwirth wrote: > I noticed the docs at > https://www.postgresql.org/docs/devel/ddl-partitioning.html still say > you can't create a foreign key referencing a partitioned table, even > though the docs for > https://www.postgresql.org/docs/devel/sql-createtable.html

docs about FKs referencing partitioned tables

2019-05-20 Thread Paul A Jungwirth
Hello, I posted this to the "clean up docs for v12" thread and it was suggested I make a new thread instead, so here it is. Sorry for the extra noise! :-) I noticed the docs at https://www.postgresql.org/docs/devel/ddl-partitioning.html still say you can't create a foreign key referencing a