Re: documentation fix for SET ROLE

On 4/2/21, 10:54 AM, "Joe Conway" wrote: > On 4/2/21 10:21 AM, Laurenz Albe wrote: >> So I think that documenting this is the way to go. I'll mark it as >> "ready for committer". > > pushed Thanks! Nathan

Re: documentation fix for SET ROLE

On 4/2/21 10:21 AM, Laurenz Albe wrote: On Mon, 2021-03-15 at 17:09 +, Bossart, Nathan wrote: On 3/15/21, 7:06 AM, "Laurenz Albe" wrote: > On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote: > > On 3/12/21, 11:14 AM, "Joe Conway" wrote: > > > Looking back at the commit history it see

Re: documentation fix for SET ROLE

On Mon, 2021-03-15 at 17:09 +, Bossart, Nathan wrote: > On 3/15/21, 7:06 AM, "Laurenz Albe" wrote: > > On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote: > > > On 3/12/21, 11:14 AM, "Joe Conway" wrote: > > > > Looking back at the commit history it seems to me that this only works > > >

Re: documentation fix for SET ROLE

On 3/15/21, 7:06 AM, "Laurenz Albe" wrote: > On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote: >> On 3/12/21, 11:14 AM, "Joe Conway" wrote: >> > Looking back at the commit history it seems to me that this only works >> > accidentally. Perhaps it would be best to fix RESET ROLE and be done

Re: documentation fix for SET ROLE

On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote: > On 3/12/21, 11:14 AM, "Joe Conway" wrote: > > Looking back at the commit history it seems to me that this only works > > accidentally. Perhaps it would be best to fix RESET ROLE and be done with > > it. > > That seems reasonable to me.

Re: documentation fix for SET ROLE

On 3/12/21, 11:14 AM, "Joe Conway" wrote: > On 3/12/21 1:16 PM, Bossart, Nathan wrote: >> My main goal of this thread is to get the RESET ROLE documentation >> fixed. I don't have a terribly strong opinion on documenting these >> special uses of "role". I lean in favor of adding it, but I wouldn

Re: documentation fix for SET ROLE

On 3/12/21 1:16 PM, Bossart, Nathan wrote: On 3/12/21, 6:35 AM, "Laurenz Albe" wrote: On Fri, 2021-03-12 at 10:16 +0100, I wrote: After sleeping on it, I have come to think that it is excessive to write so much documentation for a feature that is that unimportant. It takes some effort to come

Re: documentation fix for SET ROLE

On 3/12/21, 6:35 AM, "Laurenz Albe" wrote: > On Fri, 2021-03-12 at 10:16 +0100, I wrote: >> After sleeping on it, I have come to think that it is excessive to write >> so much documentation for a feature that is that unimportant. >> >> It takes some effort to come up with a good use case for it. >

Re: documentation fix for SET ROLE

On Fri, Mar 12, 2021 at 7:35 AM Laurenz Albe wrote: > On Fri, 2021-03-12 at 10:16 +0100, I wrote: > > After sleeping on it, I have come to think that it is excessive to write > > so much documentation for a feature that is that unimportant. > > > > It takes some effort to come up with a good use

Re: documentation fix for SET ROLE

On Fri, 2021-03-12 at 10:16 +0100, I wrote: > After sleeping on it, I have come to think that it is excessive to write > so much documentation for a feature that is that unimportant. > > It takes some effort to come up with a good use case for it. > > I think we can add a few lines to ALTER ROLE,

Re: documentation fix for SET ROLE

On Thu, 2021-03-11 at 22:30 +, Bossart, Nathan wrote: > On 3/11/21, 12:11 PM, "David G. Johnston" wrote: > > The minor bit of documentation pseudo-redundancy doesn’t bother me if I > > accept > > they are there own separate thing. The fact that set role and set session > > authorization ar

Re: documentation fix for SET ROLE

On Thursday, March 11, 2021, Bossart, Nathan wrote: > Thanks for reviewing. > > On 3/11/21, 6:59 AM, "Laurenz Albe" wrote: > > I have had a look at the patch, and while I agree that this should > > be documented, I am not happy with the patch as it is. > > > > I think we should *not* document th

Re: documentation fix for SET ROLE

On Thu, Mar 11, 2021 at 7:58 AM Laurenz Albe wrote: > I think we should *not* document that under "server configuration". > This is confusing and will lead people to think that a role is > a configuration parameter. But you cannot add > >role = myrole > > to "postgresql.conf". A role is not

Re: documentation fix for SET ROLE

I have had a look at the patch, and while I agree that this should be documented, I am not happy with the patch as it is. I think we should *not* document that under "server configuration". This is confusing and will lead people to think that a role is a configuration parameter. But you cannot ad

Re: documentation fix for SET ROLE

On Mon, Mar 8, 2021 at 4:41 PM David G. Johnston wrote: > On Thu, Feb 18, 2021 at 6:18 PM Bossart, Nathan > wrote: > >> On 2/17/21 2:12 PM, David G. Johnston wrote: >> > On Wednesday, February 17, 2021, Bossart, Nathan > > > wrote: >> > >> > >> > postgres=# AL

Re: documentation fix for SET ROLE

On Thu, Feb 18, 2021 at 6:18 PM Bossart, Nathan wrote: > On 2/17/21 2:12 PM, David G. Johnston wrote: > > On Wednesday, February 17, 2021, Bossart, Nathan > > wrote: > > > > > > postgres=# ALTER ROLE test1 SET ROLE test2; > > ALTER ROLE > > > > > > I w

Re: documentation fix for SET ROLE

On 2/17/21, 12:15 PM, "Joe Conway" wrote: > On 2/17/21 2:12 PM, David G. Johnston wrote: >> On Wednesday, February 17, 2021, Bossart, Nathan > > wrote: >> >> >> postgres=# ALTER ROLE test1 SET ROLE test2; >> ALTER ROLE >> >> >> I would not have expec

Re: documentation fix for SET ROLE

On 2/17/21 2:12 PM, David G. Johnston wrote: > On Wednesday, February 17, 2021, Bossart, Nathan > wrote: > > >     postgres=# ALTER ROLE test1 SET ROLE test2; >     ALTER ROLE > > > I would not have expected this to work - “role” isn’t a > configuration_para

Re: documentation fix for SET ROLE

On Wednesday, February 17, 2021, Bossart, Nathan wrote: > > postgres=# ALTER ROLE test1 SET ROLE test2; > ALTER ROLE > I would not have expected this to work - “role” isn’t a configuration_parameter. Its actually cool that it does, but this doc fix should address this oversight as well.

documentation fix for SET ROLE

Hi hackers, I noticed some interesting role behavior that seems to be either a bug or a miss in the documentation. The documentation for SET ROLE claims that RESET ROLE resets "the current user identifier to be the current session user identifier" [0], but this doesn't seem to hold true when "rol