Re: don't include tableam.h in nbtree.h

2025-08-14 Thread Álvaro Herrera
On 2025-Aug-05, Bertrand Drouvot wrote: > I think that makes sense. Thanks for looking! > index 1127597bb60..8282055ebca 100644 > --- a/contrib/btree_gist/btree_bool.c > +++ b/contrib/btree_gist/btree_bool.c > @@ -6,6 +6,7 @@ > #include "btree_gist.h" > #include "btree_utils_num.h" > #include

Re: don't include tableam.h in nbtree.h

2025-08-05 Thread Bertrand Drouvot
Hi, On Tue, Aug 05, 2025 at 01:09:57PM +0200, Álvaro Herrera wrote: > I noticed that nbtree.h includes tableam.h. This seems rather random > and unnecessary. This patch removes it and fixes fallout, which is > pretty minimal. We do need to add a forward declaration of struct > TM_IndexDeleteOp

don't include tableam.h in nbtree.h

2025-08-05 Thread Álvaro Herrera
I noticed that nbtree.h includes tableam.h. This seems rather random and unnecessary. This patch removes it and fixes fallout, which is pretty minimal. We do need to add a forward declaration of struct TM_IndexDeleteOp (whose full definition appears in tableam.h) so that _bt_delitems_delete_chec