Re: empty column name in error message

2019-12-17 Thread Michael Paquier
On Wed, Dec 18, 2019 at 11:23:17AM +0900, Amit Langote wrote: > Thanks for adding the test case. For the archives: this has been applied as of 2acab05. -- Michael signature.asc Description: PGP signature

Re: empty column name in error message

2019-12-17 Thread Amit Langote
On Wed, Dec 18, 2019 at 1:21 AM Tom Lane wrote: > Haven't read the patch in any detail yet, but that seems like > an improvement. And I guess we need a test case, or we'll > break it again :-( Thanks for adding the test case. Regards, Amit

Re: empty column name in error message

2019-12-17 Thread Tom Lane
Amit Langote writes: > I wonder if it's worthwhile to fix the following not-so-friendly error > message: > create index on foo ((row(a))); > ERROR: column "" has pseudo-type record Ugh. That used to work more nicely: regression=# create index fooi on foo ((row(a))); ERROR: column "pg_expres

empty column name in error message

2019-12-16 Thread Amit Langote
Hi, I wonder if it's worthwhile to fix the following not-so-friendly error message: create index on foo ((row(a))); ERROR: column "" has pseudo-type record For example, the attached patch makes it this: create index on foo ((row(a))); ERROR: column "row" has pseudo-type record Note that "row