On Tue, Jul 19, 2022 at 09:51:13PM +0900, Michael Paquier wrote:
> +1.
I have looked at that and added the extra periods, and applied it.
Thanks, Justin.
--
Michael
signature.asc
Description: PGP signature
On Tue, Jul 19, 2022 at 02:31:28PM +0200, Alvaro Herrera wrote:
> Hmm, +1, though a few of these are still missing ending periods after
> your patch.
+1.
--
Michael
signature.asc
Description: PGP signature
On 2022-Jul-19, Justin Pryzby wrote:
> https://www.postgresql.org/docs/current/error-style-guide.html#id-1.10.6.4.7
>
> git grep 'errdetail("[[:lower:]]'
> git grep 'errdetail(".*".*;' |grep -v '\."'
Hmm, +1, though a few of these are still missing ending periods after
your patch.
--
Álvaro He
Most of these are new in v15.
In any case, I'm not sure if the others ought to be backpatched.
There may be additional fixes to make with the same grepping.
>From a33bd79c2f36046463489fbd37c76d7f0c3f7a8e Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Mon, 18 Jul 2022 13:54:38 -0500
Subject: [P
