Re: error messages in extended statistics

2019-05-30 Thread Alvaro Herrera
On 2019-May-30, Tomas Vondra wrote: > Pushed and backpatched, changing most places to elog(). Thanks :-) -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: error messages in extended statistics

2019-05-30 Thread Tomas Vondra
On Wed, May 15, 2019 at 06:35:47PM +0200, Tomas Vondra wrote: On Wed, May 15, 2019 at 12:17:29PM -0400, Alvaro Herrera wrote: On 2019-May-05, Tomas Vondra wrote: OK, so here is a patch, using elog() for all places except for the input function, where we simply report we don't accept those valu

Re: error messages in extended statistics

2019-05-15 Thread Tomas Vondra
On Wed, May 15, 2019 at 12:17:29PM -0400, Alvaro Herrera wrote: On 2019-May-05, Tomas Vondra wrote: OK, so here is a patch, using elog() for all places except for the input function, where we simply report we don't accept those values. Hmm, does this actually work? I didn't know that elog()

Re: error messages in extended statistics

2019-05-15 Thread Alvaro Herrera
On 2019-May-05, Tomas Vondra wrote: > OK, so here is a patch, using elog() for all places except for the > input function, where we simply report we don't accept those values. Hmm, does this actually work? I didn't know that elog() supported errcode()/errmsg()/etc. I thought the macro definitio

Re: error messages in extended statistics

2019-05-04 Thread Tomas Vondra
On Fri, May 03, 2019 at 09:42:17PM +0200, Tomas Vondra wrote: On Fri, May 03, 2019 at 12:21:36PM -0400, Tom Lane wrote: Alvaro Herrera writes: Error reporting in extended statistics is inconsistent -- many messages that are ereport() in mvdistinct.c are elog() in the other modules. ... I think

Re: error messages in extended statistics

2019-05-03 Thread Tomas Vondra
On Fri, May 03, 2019 at 12:21:36PM -0400, Tom Lane wrote: Alvaro Herrera writes: Error reporting in extended statistics is inconsistent -- many messages that are ereport() in mvdistinct.c are elog() in the other modules. ... I think this should be cleaned up, while at the same time not giving t

Re: error messages in extended statistics

2019-05-03 Thread Tom Lane
Alvaro Herrera writes: > Error reporting in extended statistics is inconsistent -- many messages > that are ereport() in mvdistinct.c are elog() in the other modules. > ... > I think this should be cleaned up, while at the same time not giving too > much hassle for translators; for example, this m

error messages in extended statistics

2019-05-03 Thread Alvaro Herrera
Hello Error reporting in extended statistics is inconsistent -- many messages that are ereport() in mvdistinct.c are elog() in the other modules. I think what happened is that I changed them from elog to ereport when committing mvdistinct, but Tomas and Simon didn't follow suit when committing th