On Thu, Mar 07, 2019 at 11:25:10AM +0900, Michael Paquier wrote:
> On Wed, Mar 06, 2019 at 11:08:12AM -0800, Jeremy Schneider wrote:
>> If anything, I think we might just want to add comments to
>> RegisterLWLockTranches() and lwlocknames.txt with links to the doc file
>> that needs to be updated w
On Wed, Mar 06, 2019 at 11:08:12AM -0800, Jeremy Schneider wrote:
> LWLock order in documentation:
> 1) CamelCase LWLocks: individually named - see lwlocknames.txt
> 2) lowercase LWLocks: tranches
> 2a) SLRUs - see SimpleLruInit() callers on doxygen
> 2b) Shared Buffer (buffer_content, buffer_io)
>
On Wed, Mar 06, 2019 at 02:21:15PM +1300, Thomas Munro wrote:
> Here's some missing documentation.
The addition looks fine to me.
> Hmm, yeah. I wish these were alphabetised, I wish there was an
> automated warning about this, I wish these tranches were declared a
> better way that by adding cod
On Wed, Mar 6, 2019 at 2:18 PM Alvaro Herrera wrote:
> On 2019-Mar-05, Jeremy Schneider wrote:
> > It's possible I'm misreading this, but I'm thinking that commits
> > cc5f8136 and ab9e0e71 added a few tranches which we need to add to the docs.
> >
> > session_dsa, session_record_table, session_ty
On 2019-Mar-05, Jeremy Schneider wrote:
> It's possible I'm misreading this, but I'm thinking that commits
> cc5f8136 and ab9e0e71 added a few tranches which we need to add to the docs.
>
> session_dsa, session_record_table, session_typmod_table, and
> shared_tuplestore
>
> https://www.postgresq