Re: fix stale help message

2022-08-14 Thread Michael Paquier
On Sun, Aug 14, 2022 at 09:03:15PM +0800, Junwang Zhao wrote: > I'm not sure by saying `set_plan_disabling_options` do you mean > the postgres source code? If that's the case, I think most of the > installations don't have source code but just binaries, people will > reference the help message by

Re: fix stale help message

2022-08-14 Thread Junwang Zhao
Hi Michael, Thanks for your reply :) I think the goal of `help message` is to tell users(like DBA) how to use postgres, so it's better to provide a complete view. I'm not sure by saying `set_plan_disabling_options` do you mean the postgres source code? If that's the case, I think most of the

Re: fix stale help message

2022-08-14 Thread Michael Paquier
On Wed, Aug 10, 2022 at 11:32:18PM +0800, Junwang Zhao wrote: > when parsing command-line options, the -f option support disabling > 8 scan and join methods, o, b and t disable index-only scans, > bitmap index scans, and TID scans respectively, add them to the > help message. > > @@ -351,7 +351,7

Re: fix stale help message

2022-08-12 Thread Junwang Zhao
Hi peter, Sorry to bother, but I notice that you are one of the most active committers, can you pls take a look at this thread. Thanks! On Wed, Aug 10, 2022 at 11:32 PM Junwang Zhao wrote: > > when parsing command-line options, the -f option support disabling > 8 scan and join methods, o, b

fix stale help message

2022-08-10 Thread Junwang Zhao
when parsing command-line options, the -f option support disabling 8 scan and join methods, o, b and t disable index-only scans, bitmap index scans, and TID scans respectively, add them to the help message. diff --git a/src/backend/main/main.c b/src/backend/main/main.c index