Re: format of pg_upgrade loadable_libraries warning

2019-11-28 Thread Daniel Gustafsson
> On 28 Nov 2019, at 02:26, Bruce Momjian wrote: > I have applied the patch, with improved wording. I only applied this to > PG 13 since I was worried old tools might be checking for the old error > text. Should this be backpatched more? I don't think it's unreasonable to assume that there

Re: format of pg_upgrade loadable_libraries warning

2019-11-27 Thread Bruce Momjian
On Fri, Nov 15, 2019 at 12:32:55AM +0100, Daniel Gustafsson wrote: > > On 14 Nov 2019, at 23:16, Bruce Momjian wrote: > > > > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: > >> BTW, how is one supposed to "manually upgrade databases that use > >> contrib/isb"? This part is not

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Daniel Gustafsson
> On 14 Nov 2019, at 23:16, Bruce Momjian wrote: > > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: >> BTW, how is one supposed to "manually upgrade databases that use >> contrib/isb"? This part is not very clear. > > I thought you would dump out databases that use isn, drop

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Bruce Momjian
On Thu, Nov 14, 2019 at 05:49:12PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: > >> BTW, how is one supposed to "manually upgrade databases that use > >> contrib/isb"? This part is not very clear. > > > I thought you would

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Tom Lane
Bruce Momjian writes: > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: >> BTW, how is one supposed to "manually upgrade databases that use >> contrib/isb"? This part is not very clear. > I thought you would dump out databases that use isn, drop those > databases, use pg_upgrade

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Bruce Momjian
On Thu, Nov 14, 2019 at 02:46:29PM -0500, Tom Lane wrote: > Alvaro Herrera writes: > > On 2019-Oct-07, Bruce Momjian wrote: > >> and the "in database" (which I have changed to capitalized "In database" > >> in the attached patch), looks like: > >> fprintf(script, "In database: %s\n",

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Bruce Momjian
On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: > BTW, how is one supposed to "manually upgrade databases that use > contrib/isb"? This part is not very clear. I thought you would dump out databases that use isn, drop those databases, use pg_upgrade for the remaining databases,

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Oct-07, Bruce Momjian wrote: >> and the "in database" (which I have changed to capitalized "In database" >> in the attached patch), looks like: >> fprintf(script, "In database: %s\n", active_db->db_name); >> meaning it _isn't_ an output error message, but rather

Re: format of pg_upgrade loadable_libraries warning

2019-11-14 Thread Alvaro Herrera
On 2019-Oct-07, Bruce Momjian wrote: > Uh, I looked at the pg_ugprade code and the error message is: > > pg_fatal("Your installation contains \"contrib/isn\" functions which > rely on the\n" > "bigint data type. Your old and new clusters pass bigint > values\n" >

Re: format of pg_upgrade loadable_libraries warning

2019-10-08 Thread Bruce Momjian
On Mon, Oct 7, 2019 at 01:47:57PM -0400, Bruce Momjian wrote: > On Fri, Oct 4, 2019 at 11:55:21PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Oct 4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote: > > >> I would argue to include in 12.1, since 12 is what most everyone will >

Re: format of pg_upgrade loadable_libraries warning

2019-10-07 Thread Bruce Momjian
On Fri, Oct 4, 2019 at 11:55:21PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Oct 4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote: > >> I would argue to include in 12.1, since 12 is what most everyone will use > >> for > >> upgrades, and patch for .1 will help people upgrading

Re: format of pg_upgrade loadable_libraries warning

2019-10-04 Thread Tom Lane
Bruce Momjian writes: > On Fri, Oct 4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote: >> I would argue to include in 12.1, since 12 is what most everyone will use for >> upgrades, and patch for .1 will help people upgrading for 11 of the next 12 >> months. (But, your patch is more general than

Re: format of pg_upgrade loadable_libraries warning

2019-10-04 Thread Bruce Momjian
On Fri, Oct 4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote: > On Fri, Oct 04, 2019 at 05:37:46PM -0400, Bruce Momjian wrote: > > On Wed, Oct 2, 2019 at 12:23:37PM -0500, Justin Pryzby wrote: > > > Regarding the previous thread and commit here: > > >

Re: format of pg_upgrade loadable_libraries warning

2019-10-04 Thread Justin Pryzby
On Fri, Oct 04, 2019 at 05:37:46PM -0400, Bruce Momjian wrote: > On Wed, Oct 2, 2019 at 12:23:37PM -0500, Justin Pryzby wrote: > > Regarding the previous thread and commit here: > > https://www.postgresql.org/message-id/flat/20180713162815.GA3835%40momjian.us > >

Re: format of pg_upgrade loadable_libraries warning

2019-10-04 Thread Bruce Momjian
On Wed, Oct 2, 2019 at 12:23:37PM -0500, Justin Pryzby wrote: > Regarding the previous thread and commit here: > https://www.postgresql.org/message-id/flat/20180713162815.GA3835%40momjian.us >

format of pg_upgrade loadable_libraries warning

2019-10-02 Thread Justin Pryzby
Regarding the previous thread and commit here: https://www.postgresql.org/message-id/flat/20180713162815.GA3835%40momjian.us https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=60e3bd1d7f92430b24b710ecf0559656eb8ed499 I'm suggesting to reformat the warning, which I found to be