On Thu, Mar 24, 2022 at 7:43 AM Amit Kapila wrote:
>
> On Wed, Mar 23, 2022 at 9:30 AM Zhihong Yu wrote:
> >
> > On Tue, Mar 22, 2022 at 8:45 PM Amit Kapila wrote:
> >>
> >> On Tue, Mar 22, 2022 at 3:39 AM Zhihong Yu wrote:
> >>
> >> Your patch looks good to me. I have found one more similar in
On Wed, Mar 23, 2022 at 9:30 AM Zhihong Yu wrote:
>
> On Tue, Mar 22, 2022 at 8:45 PM Amit Kapila wrote:
>>
>> On Tue, Mar 22, 2022 at 3:39 AM Zhihong Yu wrote:
>>
>> Your patch looks good to me. I have found one more similar instance in
>> the same file and changed that as well accordingly. Let
On Tue, Mar 22, 2022 at 9:04 PM Zhihong Yu wrote:
>
>
> On Tue, Mar 22, 2022 at 8:45 PM Amit Kapila
> wrote:
>
>> On Tue, Mar 22, 2022 at 3:39 AM Zhihong Yu wrote:
>> >
>> > On Mon, Mar 21, 2022 at 3:05 PM Tom Lane wrote:
>> >>
>> >> Zhihong Yu writes:
>> >> >> I was looking at calls to bms_f
On Tue, Mar 22, 2022 at 8:45 PM Amit Kapila wrote:
> On Tue, Mar 22, 2022 at 3:39 AM Zhihong Yu wrote:
> >
> > On Mon, Mar 21, 2022 at 3:05 PM Tom Lane wrote:
> >>
> >> Zhihong Yu writes:
> >> >> I was looking at calls to bms_free() in PG code.
> >> >> e.g. src/backend/commands/publicationcmds
On Tue, Mar 22, 2022 at 3:39 AM Zhihong Yu wrote:
>
> On Mon, Mar 21, 2022 at 3:05 PM Tom Lane wrote:
>>
>> Zhihong Yu writes:
>> >> I was looking at calls to bms_free() in PG code.
>> >> e.g. src/backend/commands/publicationcmds.c line 362
>> >> bms_free(bms);
>> >> The above is just an ex
On Mon, Mar 21, 2022 at 3:05 PM Tom Lane wrote:
> Zhihong Yu writes:
> >> I was looking at calls to bms_free() in PG code.
> >> e.g. src/backend/commands/publicationcmds.c line 362
> >> bms_free(bms);
> >> The above is just an example, there're other calls to bms_free().
> >> Since the bms
Zhihong Yu writes:
>> I was looking at calls to bms_free() in PG code.
>> e.g. src/backend/commands/publicationcmds.c line 362
>> bms_free(bms);
>> The above is just an example, there're other calls to bms_free().
>> Since the bms is allocated from some execution context, I wonder why this
>>
>
> Hi,
> I was looking at calls to bms_free() in PG code.
>
> e.g. src/backend/commands/publicationcmds.c line 362
>
> bms_free(bms);
>
> The above is just an example, there're other calls to bms_free().
> Since the bms is allocated from some execution context, I wonder why this
> call is