Re: generating bootstrap entries for array types

2018-09-20 Thread John Naylor
On 9/21/18, Tom Lane wrote: > I did some other minor hacking (mostly, fixing the documentation) > and pushed it. Thank you. -John Naylor

Re: generating bootstrap entries for array types

2018-09-20 Thread Tom Lane
I wrote: > I did some other minor hacking (mostly, fixing the documentation) > and pushed it. BTW, I hadn't thought to measure before, but this patch cut the size of pg_type.dat by almost 40%. Nice! regards, tom lane

Re: generating bootstrap entries for array types

2018-09-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> I'm inclined to think the right way is to do the expansion always, >> and teach reformat_dat_file.pl to drop autogenerated array types >> on the way out, making this work more like the existing facilities

Re: generating bootstrap entries for array types

2018-09-20 Thread John Naylor
On 9/20/18, Dagfinn Ilmari Mannsåker wrote: > Hi again John, Hi Ilmari, My apologies -- your messages ended up in my spam folder. I only saw this thread again when Tom replied. Thanks for the review! I'll keep a look out for any future messages. -John Naylor

Re: generating bootstrap entries for array types

2018-09-20 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >>> Doing this in genbki.pl makes DBD::Pg lose its array type information, >>> since it uses Catalog::ParseData() to get it >>>

Re: generating bootstrap entries for array types

2018-09-20 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >> Doing this in genbki.pl makes DBD::Pg lose its array type information, >> since it uses Catalog::ParseData() to get it >>

Re: generating bootstrap entries for array types

2018-09-20 Thread Dagfinn Ilmari Mannsåker
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed The v2 patch is IMO ready to commit. The documentation in the

Re: generating bootstrap entries for array types

2018-09-20 Thread Dagfinn Ilmari Mannsåker
Hi again John, ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > Doing this in genbki.pl makes DBD::Pg lose its array type information, > since it uses Catalog::ParseData() to get it > (https://github.com/bucardo/dbdpg/blob/master/types.c#L439). May I > suggest moving gen_array_types() to

Re: generating bootstrap entries for array types

2018-07-12 Thread Dagfinn Ilmari Mannsåker
Hi John, John Naylor writes: >> On 4/26/18, Tom Lane wrote: >>> if I counted correctly. (Array entries should be ignored for this >>> purpose; maybe we'll autogenerate them someday.) >> >> Hmm, that wouldn't be too hard. Add a new metadata field called >> 'array_type_oid', then if it finds

generating bootstrap entries for array types

2018-05-19 Thread John Naylor
I wrote [1]: > On 4/26/18, Tom Lane wrote: >> if I counted correctly. (Array entries should be ignored for this >> purpose; maybe we'll autogenerate them someday.) > > Hmm, that wouldn't be too hard. Add a new metadata field called > 'array_type_oid', then if it finds such